Repository navigation
Avoid substring scans when checking nickname closers - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Measured benefit
A focused PHP 8.4.26 benchmark mapping an unmatched quote followed by a 16 KiB Unicode token 1,000 times took 30–31 ms before and 6–14 ms after across five paired runs. This measures the closer scan workload, not general parser throughput.
Validation
2f9d3a9518d5e3f868b9ba7fc1595c79f0692998.Exact-head CI passed all five jobs: PHP 8.3 / 8.4 / 8.5 tests (including Composer audit), static analysis (including the PHP 8.5 compatibility gate), and code style. No jobs or steps were skipped.