Skip to content

Solver: match array allocations with array deletion during cleanup - #58

Merged
martinjankoehler merged 2 commits into
masterfrom
array-lifetimes
Nov 19, 2026
Merged

martinjankoehler merged 2 commits into
masterfrom
array-lifetimes

Conversation

@martinjankoehler

@martinjankoehler martinjankoehler commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #57

Use matching array deletion in solver and refinement cleanup. AddressSanitizer reproduces the previous allocation/deallocation mismatch on the existing small three-cube test; successful numerical behavior is unchanged.

Use matching array deletion in solver and refinement cleanup. AddressSanitizer reproduces the previous allocation/deallocation mismatch on the existing small three-cube test; successful numerical behavior is unchanged.
Integrate #69 before repeating Windows package validation.
@martinjankoehler
martinjankoehler marked this pull request as ready for review November 19, 2026 20:22
@martinjankoehler
martinjankoehler merged commit 22cd2d5 into master Nov 19, 2026
12 checks passed
martinjankoehler added a commit that referenced this pull request Nov 19, 2026
Integrate #51, #56 and #58 without dropping feature regressions.
@martinjankoehler
martinjankoehler deleted the array-lifetimes branch November 19, 2026 20:39
martinjankoehler added a commit that referenced this pull request Nov 19, 2026
Integrate #51, #56, #58 and #62 without dropping feature regressions.
martinjankoehler added a commit that referenced this pull request Nov 19, 2026
Integrate #51, #56, #58 and #62 without dropping feature regressions.
martinjankoehler added a commit that referenced this pull request Nov 19, 2026
Integrate #51, #56, #58 and #62 without dropping feature regressions.
martinjankoehler added a commit that referenced this pull request Nov 19, 2026
Integrate #51, #56, #58 and #62 without dropping feature regressions.
martinjankoehler added a commit that referenced this pull request Nov 19, 2026
Integrate #51, #56, #58 and #62 without dropping feature regressions.
martinjankoehler added a commit that referenced this pull request Nov 19, 2026
Integrate #51, #56, #58 and #62 without dropping feature regressions.
martinjankoehler added a commit that referenced this pull request Nov 19, 2026
Retain #58 in the relocated preconditioner allocation block.
martinjankoehler added a commit that referenced this pull request Nov 19, 2026
Integrate #51, #56, #58 and #62 without dropping feature regressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Solver: array allocations are released with scalar delete

1 participant