Update scalafmt#252
Open
mdedetrich wants to merge 1 commit intoiheartradio:masterfrom
Open
Conversation
mdedetrich
commented
Mar 18, 2023
| with: | ||
| version: '3.4.3' | ||
| version: '3.7.2' | ||
| arguments: '--list --mode diff-ref=origin/master' |
Author
There was a problem hiding this comment.
This change means that the scalafmt github action check will only run on files that have actually changed (according to origin/master) rather than checking that the entire codebase is formatting.
mdedetrich
commented
Mar 18, 2023
| pull_request: | ||
| branches: ['**'] | ||
|
|
||
| env: |
mdedetrich
commented
Mar 18, 2023
| jobs: | ||
| build: | ||
| name: Code is formatted | ||
| strategy: |
Author
There was a problem hiding this comment.
Matrix here is pointless, we will always run this on ubuntu-latest
mdedetrich
commented
Mar 18, 2023
| ] | ||
| rewrite.rules = [RedundantBraces, RedundantParens] | ||
|
|
||
| fileOverride { |
Author
There was a problem hiding this comment.
This is no longer needed because scalafmt now provides a project.layout = standardConvention which applies the correct Scala dialects according to sbt's folder layout as long as its the standard layout (which in this projects case it is).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates scalafmt which also brings in some improvements (noted below).