Address TODO items for version 2.0.1 #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python improvements: - Extract shared within-transformation logic to utils.py - New demean_by_group() for one-way fixed effects demeaning - New within_transform() for two-way (unit + time) FE transformation - Reduces code duplication across estimators.py, twfe.py, sun_abraham.py, bacon.py - Fix DataFrame fragmentation warning by building columns in batch Rust backend optimizations: - Use Cholesky factorization for matrix inversion in linalg.rs - More efficient for symmetric positive-definite matrices (X'X) - Approximately half the operations of general LU decomposition - Reduce bootstrap allocations in bootstrap.rs - Allocate directly into pre-allocated buffer - Eliminates intermediate Vec<Vec<f64>> -> flatten -> Array2 pattern - Single allocation instead of two Version bump: 2.0.0 -> 2.0.1
The Rust backend optimizations (Cholesky factorization, reduced allocations) could not be tested in CI due to missing OpenBLAS library. Reverting these changes to keep v2.0.1 focused on tested Python improvements only. The Rust optimizations remain in TODO.md for future implementation when proper testing infrastructure is available.
igerber
pushed a commit
that referenced
this pull request
Jan 13, 2026
Review of the TODO items v2.0.1 PR covering: - Methodology: Verified numerical equivalence of new utility functions - Code quality: Well-documented, consistent API design - Performance: ~5x speedup from pandas groupby vs numpy loops - Maintainability: Eliminates 4 duplicate implementations Recommendation: APPROVE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python Code Quality: Within-Transformation Extraction