fix(deploy): correct Aliyun runtime stop URL - #698
Open
XiaoSeS wants to merge 2 commits into
Open
Conversation
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
runtime.shURL in the post-install stop command.scripts/runtime.sh.Why
Aliyun publishes the runtime entry point at
/runtime.sh, while the repository stores it at/scripts/runtime.sh. The shared completion message always appended/scripts/runtime.sh, soruntime.sh --aliyunprinted a stop command that returned 404 even though installation and startup succeeded.How
Resolve
RUNTIME_SCRIPT_URLwhen selecting the download source, then reuse that exact URL in the completion message.Testing
sh -n scripts/runtime.shbash -n scripts/tests/runtime-secret-test.shbash scripts/tests/runtime-secret-test.shbash scripts/tests/validate-release-config-test.shbash scripts/tests/workflow-security-test.shbash scripts/tests/dev-web-host-test.shbash scripts/tests/publish-cli-test.shmake typecheck-webmake lint-webmake stagingwas not run because the shared host already has unrelated services bound to the fixed staging ports 5432, 80, and 8080. Those services were left untouched.Impact
No installation, startup, image, configuration, or API behavior changes. This only corrects the operator-facing stop command printed after an Aliyun deployment.
Ordinary-user validation follow-up
A clean
v0.2.16README deployment on the open-source validation host reproduced the defect: the printed/scripts/runtime.shURL returns 404, the shell pipeline exits 0, and all five containers remain running. The follow-up commit also preserves--aliyunin the corrected command so lifecycle operations continue using the same public distribution source instead of falling back to GitHub Raw.The public OSS installer otherwise passed root-path install, registry pull, 15/15 administrator smoke, same-volume restart, and clean reinstall checks. The three official Dockerfiles also built from a clean public tag checkout and their resulting images passed 15/15 smoke.