feat(metadata): add compliance snapshot mappings - #697
Merged
Conversation
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
XiaoSeS
force-pushed
the
feat/compliance-metadata-snapshot
branch
from
August 7, 2026 07:46
57bb94e to
da5c3cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #556.
This PR adds optional SkillHub/Astron compliance metadata for skill versions:
x-astron-compliancefrontmatter during publish;parsedMetadataJson.complianceSnapshot;standard,version,controlId, andtitleso searches likeT1059can find mapped skills.Out of scope:
Validation
ComplianceMetadataServiceTestSkillPackageValidatorTestSkillPublishServiceTestComplianceSnapshotProjectionServiceTestReviewSkillDetailAppServiceTestSkillControllerTestReviewPortalControllerTestPostgresSearchRebuildServiceTestpnpm --dir web exec vitest run src/features/skill/compliance-snapshot-panel.test.tsx src/features/review/review-skill-detail-section.test.tsxpnpm --dir web run typecheckpnpm --dir web run lintTMPDIR=<private-run-dir> ./scripts/check-openapi-generated.shskillhub-server:stagingscripts/smoke-test.sh http://localhost:8080: 15 passed, 0 failedx-astron-compliancecomplianceSnapshot.items[0].controlId = T1059complianceSnapshotT1059returnedcompliance-runtime-556Notes
The local staging web container required a private compose override setting
SKILLHUB_TRUST_FORWARDED_PROTO=falsebecausedocker-compose.staging.ymlusesnginx:alpinedirectly rather than the web image default.
compose.release.ymlalready carries this variable.That staging-only gap is not changed in this PR.