fix(docs): report a missing node type registry instead of failing as a defect - #2
Merged
Merged
Conversation
…a defect check_node_types.py reads the node type registry from the sibling urirun checkout via MONOREPO/urirun/adapters/python. That path exists only in the monorepo layout, so an isolated clone of this repository - a CI checkout on its own - raised ModuleNotFoundError: No module named 'urirun' and failed `make test` for a reason unrelated to the documentation being checked. It now detects the missing registry and skips with a stated reason. An environment limit is reported as one instead of masquerading as a documentation defect. Where the registry must be present, set DOCS_REQUIRE_NODE_TYPE_REGISTRY=1 and its absence fails. This matters beyond this repository: subactor/repair-agent had added a hardcoded exemption swallowing exactly this failure string during its full validation stage, which turned a real failing test into a pass for every repository it validates. With the cause fixed here, that exemption can be removed. Verified: monorepo checkout runs the full check, 10 node types and 0 errors; an isolated copy skips and `make test` exits 0; with DOCS_REQUIRE_NODE_TYPE_REGISTRY=1 the isolated copy exits 1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/check_node_types.pyreads the node type registry from the sibling urirun checkout:That path exists only in the monorepo layout. An isolated clone of this repository — a CI checkout on its own — raised
ModuleNotFoundError: No module named 'urirun'and failedmake testfor a reason that has nothing to do with the documentation being checked.Change
The missing registry is detected and the check skips with a stated reason, so an environment limit is reported as one rather than masquerading as a documentation defect. Where the registry must be present,
DOCS_REQUIRE_NODE_TYPE_REGISTRY=1makes its absence a failure.Why this matters beyond this repository
subactor/repair-agenthad added a hardcoded exemption swallowing exactly this failure string during its full validation stage — turning a real failing test into a pass for every repository it validates, forever. That is a safety gate weakened to work around a defect that lives here. With the cause fixed, the exemption can be removed.Verification
SKIP: node type registry not found …,make testexits 0DOCS_REQUIRE_NODE_TYPE_REGISTRY=1🤖 Generated with Claude Code