Improve handling of time stamp pattern in factories#331
Draft
ckittl wants to merge 28 commits into
Draft
Conversation
…asedWeatherValueFactory
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #331 +/- ##
============================================
- Coverage 77.97% 77.95% -0.02%
- Complexity 2102 2105 +3
============================================
Files 257 257
Lines 8407 8401 -6
Branches 815 814 -1
============================================
- Hits 6555 6549 -6
- Misses 1447 1449 +2
+ Partials 405 403 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…emeOfCOSMOWeatherData
…ng the implementation
ckittl
force-pushed
the
ck/#330-factoryTimestampPattern
branch
from
fc8fedd to
f25150e
Compare
Member
|
@danielfeismann, @sebastian-peter I think this PR and the related issue can be closed, since we removed the time pattern input from the factories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #330. Take care of #329 beforehand.