Repository navigation
Rename the application display name to SPA Reference - #24
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SPA Development ReferencetoSPA Referenceto match the renamed repositoryfrontend/index.html)APP_TITLEinfrontend/src/app/App.tsx)info.title(SPA Reference API)doc/images/getting-started/from an empty database with the same UI workflow, sodoc/GETTING_STARTED.mdsection 13 shows the new nameValidation
git grep -n "SPA Development Reference"returns no matchdoc/GETTING_STARTED.mdresolvegit diff --check,npm run format:check,npm run lint,npm run typecheck,npm test,npm run build,npm run openapi:lint, andnpm run api:checkpassnpm run demo:reset/npm run demoshowsSPA Referencein the tab title and header, with all three role buttonsScope
Display name and screenshots only. The repository slug, the generic "SPA development reference application" prose,
@spa-ref/*package names, and the Compose project and volume names are unchanged.Post-merge first-time-user test
Tested
masteratc07374cb97da45832a502f9a9e2454d1ca982f1a(this PR merged, plus thedoc/VERSIONSv1.0 date update) from a fresh clone ofhttps://github.com/id774/spa-reference.git, following onlyREADME.mdanddoc/GETTING_STARTED.md, after removing the previous demo container, volume, network, and thepostgres:17image.npm ci,npm run demo).nvmrc= 24), npm 10.8.3, Docker 29.7.2, Docker Compose v5.4.0; no AWS environment variables or~/.awsnpm ciexits 0npm run demopullspostgres:17, waits until healthy, generates the Prisma client, applies20261003054124_init, starts the backend ("mode":"local") and the frontend, then printsLocal demo is ready.; no.env, AWS, or Cognito is requestedhealthyandpg_isreadyaccepts connections;/health/readyreturns HTTP 200{"status":"ok"}; the frontend returns HTTP 200 with<title>SPA Reference</title>; ports 5173, 3000, and 55432 listen on127.0.0.1onlySPA Reference; the signed-out screen shows Continue as Requester / Approver / Administrator, and Continue as Requester reaches My Requests ("There are no requests yet."), matching screenshots 01 and 02 in section 13Ctrl+Cleaves notsx,vite, ordemo.mjsprocess, releases ports 5173 and 3000, and keeps the PostgreSQL container and volume as documentedgit status --shortis empty before and after the testFinding (MINOR, not fixed): during "Generating the Prisma client", the Prisma CLI showed an interactive prompt ("Install Prisma's agent skills ...? Yes / No", closes in 30s, suppressible with
--no-hints). Without an answer it continued after 30 seconds and recorded the offer in~/.config/prisma-nodejs/skills-offer.json, so it is not shown again for the same user. Startup was not blocked.