feat: add customizable database connection settings for FreeRadius #18
Merged
jozefrebjak merged 1 commit intodevelopfrom Feb 24, 2025
Merged
feat: add customizable database connection settings for FreeRadius #18jozefrebjak merged 1 commit intodevelopfrom
jozefrebjak merged 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the FreeRadius configuration and database migration classes to simplify and improve the configuration management. The most important changes include adding a new database configuration array, updating the database connection settings, and removing unnecessary dependencies.
Improvements to FreeRadius configuration:
src/Config/FreeRadius.php: Added a newdatabaseconfiguration array to customize the DB connection settings.Updates to database migration:
src/Database/Migrations/2024-01-21-223112_create_radius_tables.php: Removed the import and usage of theFreeRadiusconfig class and replaced it with thesettingfunction to retrieve configuration values. [1] [2]Updates to base model:
src/Models/BaseModel.php: Removed the import and usage of theFreeRadiusconfig class and replaced it with thesettingfunction to retrieve configuration values.