Skip to content

fix: Remove coursenumasdecimal#1569

Merged
KevinWu098 merged 1 commit intomainfrom
gyan/analytics-fix
Apr 11, 2026
Merged

fix: Remove coursenumasdecimal#1569
KevinWu098 merged 1 commit intomainfrom
gyan/analytics-fix

Conversation

@xgraceyan
Copy link
Copy Markdown
Contributor

Summary

I lwk dont know what this function does now so we remove it

Test Plan

Issues

Closes #

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Copy Markdown
Contributor

@Choollol Choollol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a small optional comment

action: analyticsEnum.classSearch.actions.ADD_COURSE,
label: courseDetails.deptCode,
value: courseNumAsDecimal(courseDetails.courseNumber),
label: courseDetails.deptCode + courseDetails.courseNumber,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick: Could add a space between to make it slightly more readable, but not important

@KevinWu098
Copy link
Copy Markdown
Member

bump

@KevinWu098 KevinWu098 merged commit b5c000e into main Apr 11, 2026
4 checks passed
dsnsgithub pushed a commit that referenced this pull request Apr 13, 2026
brelieu05 pushed a commit that referenced this pull request Apr 14, 2026
AureliaSindhu pushed a commit that referenced this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants