Skip to content

fix: enable auto save and hover to preview by default#1549

Closed
dsnsgithub wants to merge 2 commits intomainfrom
feat/autosave-by-default
Closed

fix: enable auto save and hover to preview by default#1549
dsnsgithub wants to merge 2 commits intomainfrom
feat/autosave-by-default

Conversation

@dsnsgithub
Copy link
Copy Markdown
Member

@dsnsgithub dsnsgithub commented Mar 5, 2026

Summary

Enables auto save and hover to preview by default.

Hover to preview has some minor issues when adding new sections which I can fix.

Request for comment.

Test Plan

Issues

Closes #

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/antalmanac/src/stores/SettingsStore.ts">

<violation number="1" location="apps/antalmanac/src/stores/SettingsStore.ts:107">
P1: Bug: `autoSaveSchedule` in `ActionTypesStore.ts` (line 131) still uses the old default-off logic (`getLocalStorageAutoSave() == 'true'`). For new users with no localStorage value, the UI will show auto-save as enabled, but saves won't actually trigger. The same logic change needs to be applied in `ActionTypesStore.ts` (or it should read from `useAutoSaveStore` instead of directly from localStorage).</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread apps/antalmanac/src/stores/SettingsStore.ts
@dsnsgithub
Copy link
Copy Markdown
Member Author

@cubic

@cubic-dev-ai
Copy link
Copy Markdown
Contributor

cubic-dev-ai Bot commented Mar 5, 2026

@cubic

@dsnsgithub I have started the AI code review. It will take a few minutes to complete.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@alexespejo
Copy link
Copy Markdown
Collaborator

Should we close since fixes to auto save will be blocking? @dsnsgithub

@dsnsgithub
Copy link
Copy Markdown
Member Author

Should we close since fixes to auto save will be blocking? @dsnsgithub

I don't see any harm in leaving this PR up, apart from a stale PR.

I can make a "enable auto save by default" issue, set this PR to close it, then mark the issue as blocked by another issue ("autosave may lead to data loss").

If that is too complex or not worth it, feel free to close the PR.

@KevinWu098
Copy link
Copy Markdown
Member

Gonna close this as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants