fix: enable auto save and hover to preview by default#1549
Closed
dsnsgithub wants to merge 2 commits intomainfrom
Closed
fix: enable auto save and hover to preview by default#1549dsnsgithub wants to merge 2 commits intomainfrom
dsnsgithub wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/antalmanac/src/stores/SettingsStore.ts">
<violation number="1" location="apps/antalmanac/src/stores/SettingsStore.ts:107">
P1: Bug: `autoSaveSchedule` in `ActionTypesStore.ts` (line 131) still uses the old default-off logic (`getLocalStorageAutoSave() == 'true'`). For new users with no localStorage value, the UI will show auto-save as enabled, but saves won't actually trigger. The same logic change needs to be applied in `ActionTypesStore.ts` (or it should read from `useAutoSaveStore` instead of directly from localStorage).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Member
Author
Contributor
|
@dsnsgithub I have started the AI code review. It will take a few minutes to complete. |
Collaborator
|
Should we close since fixes to auto save will be blocking? @dsnsgithub |
Member
Author
I don't see any harm in leaving this PR up, apart from a stale PR. I can make a "enable auto save by default" issue, set this PR to close it, then mark the issue as blocked by another issue ("autosave may lead to data loss"). If that is too complex or not worth it, feel free to close the PR. |
Member
|
Gonna close this as stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables auto save and hover to preview by default.
Hover to preview has some minor issues when adding new sections which I can fix.
Request for comment.
Test Plan
Issues
Closes #