Phase 3: CCC Udt integration investigation#21
Conversation
Decision: subclass CCC Udt as IckbUdt, overriding infoFrom() for multi-representation balance (xUDT + receipts + deposits). Header access via client.getTransactionWithHeader(). Conservation law enforced on-chain, not in infoFrom.
Update infoFrom override strategy (single override point, not getInputsInfo/getOutputsInfo), correct fork-scripts paths in phase-01 summaries, and incorporate CCC Udt investigation results into research documents.
- Update all SmartTransaction/CapacityManager references to note deletion in Phase 1 (ARCHITECTURE, CONCERNS, CONVENTIONS) - Update fork-scripts paths from ccc-fork/*.sh to fork-scripts/*.sh (PROJECT, CONCERNS, CONVENTIONS, STACK, STRUCTURE) - Add fork-scripts/ directory tree and @generated markers (STRUCTURE) - Mark resolved concerns as RESOLVED (CONCERNS) - Update code examples to current APIs: findUdts, isUdt, collect (CONVENTIONS) - Update 64-output DAO limit references to CCC core (CONCERNS)
Summary of ChangesHello @phroi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request marks the successful completion of Phase 3, which focused on the critical integration of iCKB's unique multi-representation UDT value with the CCC framework. Through extensive investigation, a clear strategy has been established to subclass CCC's Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request delivers on Phase 3 of the project, which is a design investigation for integrating iCKB's UDT with CCC's Udt class. The changes primarily consist of extensive documentation updates. This includes new, detailed investigation and decision documents for Phase 3, as well as updates to existing planning, architecture, and research documents to reflect the findings. A key outcome documented is the decision to subclass udt.Udt and override the infoFrom() method. The PR also includes a repository-wide refactoring, renaming the ccc-dev directory and related scripts to a more generic ccc-fork and fork-scripts structure. The documentation changes are thorough, consistent, and provide a clear path forward for subsequent implementation phases. No issues were found in the changes.
|
LGTM Phroi %114 |
1 participant
Why
Phase 3 delivers the design investigation for integrating iCKB's multi-representation UDT value with CCC's
Udtclass. Also refreshes codebase docs that had gone stale after Phase 1 deletions.Changes
udt.UdtasIckbUdtwithinfoFrom()override for xUDT + receipts + depositsinfoFromoverride point, fork-scripts paths) into research and phase-01/02 docs