Repository navigation
Conversation
Records the decided design and phases for replacing the single-grid map model with authored map layers: HEREDOC nowdoc grids in layers/ with integer-prefixed renamable filenames, topmost-occupied-wins collision with PASS_THROUGH, per-layer tiles2d crop tables and one tile batch per layer, terminal-invisible decoration layers, and the reference migration through Last Legend. Multi-batch layer painting is verified against the renderer's v2 paint plan.
The renderer checkout moved from website/gpui-renderer to the workspace root; the evidence pointer follows it.
The boundary is now provisioned by the Console's renderer:install command from verified renderer packages produced in each renderer implementation's own repository, replacing the aspirational packager wording. Publishing downloadable packages for players remains open.
…d update references
… disk Artwork changes throughout development; supplying the right asset is the developer's job and the image on disk is the moment's truth. An asset now fails only when it is missing, not a PNG, or corrupt. Authored battler crops and pivots reconcile to the current image at battle start: an overlapping crop clamps, a crop the image no longer contains falls back to the whole image, and both render best-effort with the mismatch logged for the author. Any other failure while assembling the graphical presentation, a missing catalog under an explicit arena included, logs loudly and degrades that one battle to the terminal presentation. Presentation never decides whether combat happens.
…al presentation and authoring tools
Render Main Menu, Equipment and Status through shared theme data and preserve graphical underlays for supported modals. Keep artwork replaceable, separate semantic input hints, and apply consistent card, button and footer treatments. Validation: 335 focused tests (7673 assertions) pass on PHP 8.4 and 8.5; scoped static analysis passes. Silent macOS GPUI exported-frame inspection covers the final menu, character focus and alert layouts; not a full interactive playthrough. Linux/WSLg remains untested.
Record the reusable menu and replaceable artwork contracts, accepted visual refinements, animation sequencing and outstanding authoring/admission limits. Preserve the authored effect-plan decisions.
Add bounded canvas compositing and focus-aware title playback, shared Save/Load and settings views, transparent panel corners, and left-aligned narrative prose. Require explicit confirmation for self-targeted battle actions and support generic per-troop arena formations. Include regression coverage and implementation evidence.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2161b83d8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Limits