Skip to content

Fix: CSV import origin in transaction API responses (Fixes #2) - #26

Open
theanilpaudel wants to merge 1 commit into
icastanon:mainfrom
theanilpaudel:fix/2-expose-csv-import-origin
Open

theanilpaudel wants to merge 1 commit into
icastanon:mainfrom
theanilpaudel:fix/2-expose-csv-import-origin

Conversation

@theanilpaudel

Copy link
Copy Markdown

Summary

Exposed transaction import provenance fields (importId and importRowNumber) in the API service transaction responses.

While PostgreSQL migration V18__Add_import_identity_to_financial_transaction.sql already added import_id and import_row_number to financial_transaction and the worker populates them during CSV ingestion, these fields were omitted from the API service entity and response DTOs. This change maps these read-only provenance fields in JPA and includes them across all transaction read/write API endpoints (FinancialTransactionResponse).

Changes:

  • Added importId (Long) and importRowNumber (Integer) scalar fields to FinancialTransaction entity.
  • Updated FinancialTransactionResponse DTO to include nullable importId and importRowNumber.
  • Updated FinancialTransactionMapper to map provenance fields from entity to response DTO.
  • Updated controller test assertions (MockMvc) and mapper tests to verify importId and importRowNumber

Related issue

Closes #2

Verification

  • Automated Tests: Executed unit and integration test suites for the transaction domain module:
    FinancialTransactionControllerTest

@icastanon icastanon left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution. I approved and merged.

@theanilpaudel

theanilpaudel commented Sep 5, 2026 •

Copy link
Copy Markdown
Author

Hi @icastanon.
Looks like an issue with LOCALSTACK_AUTH_TOKEN on github secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose CSV import origin in transaction API responses

2 participants