Fix: CSV import origin in transaction API responses (Fixes #2) - #26
Open
theanilpaudel wants to merge 1 commit into
Open
theanilpaudel wants to merge 1 commit into
theanilpaudel wants to merge 1 commit into
Conversation
icastanon
approved these changes
Sep 4, 2026
icastanon
left a comment
Owner
There was a problem hiding this comment.
Looks good. Thanks for the contribution. I approved and merged.
Author
|
Hi @icastanon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposed transaction import provenance fields (
importIdandimportRowNumber) in the API service transaction responses.While PostgreSQL migration
V18__Add_import_identity_to_financial_transaction.sqlalready addedimport_idandimport_row_numbertofinancial_transactionand the worker populates them during CSV ingestion, these fields were omitted from the API service entity and response DTOs. This change maps these read-only provenance fields in JPA and includes them across all transaction read/write API endpoints (FinancialTransactionResponse).Changes:
importId(Long) andimportRowNumber(Integer) scalar fields toFinancialTransactionentity.FinancialTransactionResponseDTO to include nullableimportIdandimportRowNumber.FinancialTransactionMapperto map provenance fields from entity to response DTO.MockMvc) and mapper tests to verifyimportIdandimportRowNumberRelated issue
Closes #2
Verification