Skip to content

BAI-1078 add CODEOWNERS catch-all - #179

Merged
imranq2 merged 1 commit into
mainfrom
SH-BAI-1078
Nov 15, 2026
Merged

imranq2 merged 1 commit into
mainfrom
SH-BAI-1078

Conversation

@sean-can-bwell

@sean-can-bwell sean-can-bwell commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Adds a catch-all rule to the existing CODEOWNERS in icanbwell/language-model-common so each change has a named group accountable for it. It is placed first, so the existing rules are unchanged and still take precedence.

Owners are the people with the most recent activity here, with team members added so there are at least three.
@icanbwell/bailey-ai does not have write access to this repository yet, so GitHub ignores that line until it does; the individuals listed beside it take effect now.
Some owners were added to reach three and are a best guess; if the list is wrong, edit the file in this PR or after it merges.

Evidence (last 90 days, share of commits, merged PRs and reviews): each commit counts 1, each merged PR authored 2, each approving review 2 and each co-authored commit 0.5, as a share of everyone's total in that window.

Merge behavior: CODEOWNERS only requests reviewers on PRs here; it does not by itself block merging.

Edit the file in this PR directly if the owners should differ.
Review the list, edit it freely, and remove the Catch-all owners added line once you have reviewed it.

If this PR is approved, please merge it; there is no need to wait for Sean Hegarty.

@sean-can-bwell sean-can-bwell added risk:standard Medium: additive or local runtime change, no contract break type:feature PR type: feature do-not-release Do not cut a release for this PR (docs/tests only) labels Nov 14, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@kenanspruill kenanspruill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Reviewer Approved - Small Updates/Consider Updating

Adds a * catch-all line above the existing EA rules in CODEOWNERS. Placement is correct: under last-match-wins, /AGENTS.md and /CLAUDE.md still resolve to @icanbwell/enterprise-architecture. Nothing blocks merge. The items below are optional.

Should fix (no blocker):

  • The evidence percentages don't reproduce from the window you state. Over the last 90 days, commits on main are 64 imranq2, 15 sean-can-bwell and 26 dependabot. That puts imranq2 near 57% of all commits (body says 54.3%) and sean-can-bwell near 13% (body says 10.7%). The body doesn't say how commits, merged PRs and reviews are combined. alvinhenrick has 69 reviews on merged PRs in the window, so the ranking holds on reviews. Either state the method or refresh the numbers.

Nit:

  • The dated comment at the top of the CODEOWNERS block will go stale once the list changes. The body already says to remove the line after review, so this is just a reminder.

Checked and clean:

  • Ordering: the catch-all is first, so the EA rules below it win for AGENTS.md and CLAUDE.md, as the body says.
  • Base is main, one file, 3 added lines.
  • Team access: the bailey-ai team has no repo-level grant (the team-repo endpoint returns 404), which is consistent with the body. I could not check write permission directly.
  • CI at head 5ac8488: build_and_test, Check Commit Message, Aikido and Gecko Security Review pass. Claude Code Review was skipped, not failed.

Not verified: how GitHub parses a CODEOWNERS line that contains an owner without write access. Check the code owners error view after merge to confirm the individual owners still take effect.

@imranq2
imranq2 merged commit bf86bd5 into main Nov 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-release Do not cut a release for this PR (docs/tests only) risk:standard Medium: additive or local runtime change, no contract break type:feature PR type: feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants