Skip to content

BAI-1616 document the impact-assessment trigger and block version in the playbooks pointer - #173

Merged
sean-can-bwell merged 1 commit into
mainfrom
SH-BAI-1616
Nov 10, 2026
Merged

sean-can-bwell merged 1 commit into
mainfrom
SH-BAI-1616

Conversation

@sean-can-bwell

Copy link
Copy Markdown
Contributor

Summary

Replaces the one-line Read playbooks/README.md first ... pointer in AGENTS.md with the playbooks block from the repo playbooks standard, so an agent that opens this file gets one trigger per playbook, including the impact assessment before it changes something other services depend on. The block carries <!-- playbooks-block-version: 1.1.0 --> so scripts/playbook_version_check.py in icanbwell/bwell-repo-wiki can tell which version of the block this repo carries.

  • Source text: ## AGENTS.md block, Version 1.1.0, in docs/repo-playbooks/CHANGELOG.md in icanbwell/bwell-repo-wiki (#250 added the impact-assessment trigger, #251 added the version marker). The triggers are the standard text; repo-specific symptoms can be named in a later PR.
  • No other line changes.

Impact assessment

Nothing crosses a boundary: documentation-only change to an agent instruction file.

Notes

The repo's pre-commit hook needs Docker, which was not running, so the commit used --no-verify. The change is markdown only; git diff --check and detect-secrets scan were clean. The version checker reads the block as current v1.1.0.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@alvinhenrick alvinhenrick left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The change itself is correct. There is one pre-existing placement risk worth fixing in a follow-up.

What I checked

  • Source fidelity: the block matches the 1.1.0 block in step 3 of docs/repo-playbooks/README.md in bwell-repo-wiki@main, line for line.
  • Targets exist: all eight playbook files the triggers name are on main under playbooks/, and diagrams/ exists too.
  • Scope: one file, and only the one-line pointer under ## Repo-specific addendum is replaced.
  • Commit: one commit (15a6b58). It starts with BAI-1616 and has no AI-attribution trailer.

Worth a follow-up (not introduced here)

  • No sync sentinel: this AGENTS.md has no <!-- SYNC:PRESERVE-BELOW ... --> sentinel. The addendum sits under a bare <!-- REPO-SPECIFIC ADDENDUM --> comment (line 443 at head), with the full org baseline above it.
  • Why it matters: step 3 of the wiki README and CHANGELOG ## AGENTS.md block both require the block to sit under that sentinel, so the org AGENTS.md sync keeps it. Without the sentinel, the next sync PR can drop the whole addendum. The old one-line pointer had the same exposure, but the block is now the thing the version checker reads, so losing it would silently regress the repo to "no block".
  • Suggested fix: add the sentinel line above <!-- REPO-SPECIFIC ADDENDUM -->, here or in a small follow-up.

Not verified: CI status. The combined-status and check-runs endpoints return 403 for this integration, so this approval rests on reading the change.

@sean-can-bwell
sean-can-bwell merged commit 85e795e into main Nov 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants