Repository navigation
BAI-1380 accept ADR 0009 (cache per-client config overrides) - #172
Merged
Merged
Conversation
alvinhenrick
approved these changes
Nov 9, 2026
alvinhenrick
left a comment
There was a problem hiding this comment.
Approving at df88d8e.
Checked:
- The diff is the single
Status:line inadrs/0009-cache-per-client-config-overrides.md, fromproposedtoaccepted (2026-11-09, Imran Qureshi; ...). Nothing else in the ADR changes: deciders, options, TTL defaults and the "ships behind a flag, default off" note all stay the same, which matches the description. - One commit, the BAI-1380 key is in the title and commit, and there's no AI-attribution trailer.
- Scope is right. The flag flip itself stays in baileyai #622, so merging this changes no runtime behavior in language-model-common.
Nit, non-blocking: the Date: line still says 2026-10-30 (the proposal date) while the status says 2026-11-09. That's fine if Date means "proposed"; MADR usually treats it as the date of the last status change.
I can't verify CI from this integration (the status and check-runs endpoints return 403), so this approval rests on the diff, not a green build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Marks ADR 0009 (cache per-client config overrides in the shared model-config store) as accepted. Status line only; the ADR text and defaults are unchanged. Decider: Imran Qureshi.
Scope
MODEL_CONFIG_OVERRIDE_CACHE_ENABLED, default off) and the baileyai flag rollout, which is baileyai PR #622 (it sets the flag to true in the helm values; that PR was blocked on this acceptance).Notes
Docs-only. TTL defaults in the ADR (900 s / 300 s / 86400 s) are accepted as written and remain env-configurable.