Skip to content

BAI-1380 accept ADR 0009 (cache per-client config overrides) - #172

Merged
imranq2 merged 1 commit into
mainfrom
IQ-BAI-1380
Nov 10, 2026
Merged

imranq2 merged 1 commit into
mainfrom
IQ-BAI-1380

Conversation

@imranq2

@imranq2 imranq2 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Marks ADR 0009 (cache per-client config overrides in the shared model-config store) as accepted. Status line only; the ADR text and defaults are unchanged. Decider: Imran Qureshi.

Scope

  • Covers: the ADR status change.
  • Defers: the code that implements the cache (shipped behind MODEL_CONFIG_OVERRIDE_CACHE_ENABLED, default off) and the baileyai flag rollout, which is baileyai PR #622 (it sets the flag to true in the helm values; that PR was blocked on this acceptance).

Notes

Docs-only. TTL defaults in the ADR (900 s / 300 s / 86400 s) are accepted as written and remain env-configurable.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@alvinhenrick alvinhenrick left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at df88d8e.

Checked:

  • The diff is the single Status: line in adrs/0009-cache-per-client-config-overrides.md, from proposed to accepted (2026-11-09, Imran Qureshi; ...). Nothing else in the ADR changes: deciders, options, TTL defaults and the "ships behind a flag, default off" note all stay the same, which matches the description.
  • One commit, the BAI-1380 key is in the title and commit, and there's no AI-attribution trailer.
  • Scope is right. The flag flip itself stays in baileyai #622, so merging this changes no runtime behavior in language-model-common.

Nit, non-blocking: the Date: line still says 2026-10-30 (the proposal date) while the status says 2026-11-09. That's fine if Date means "proposed"; MADR usually treats it as the date of the last status change.

I can't verify CI from this integration (the status and check-runs endpoints return 403), so this approval rests on the diff, not a green build.

@imranq2
imranq2 merged commit b52e2dc into main Nov 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants