Repository navigation
Conversation
| uses: gsactions/commit-message-checker@v2 | ||
| with: | ||
| pattern: '^(Bump|Merge|Revert|Reapply|build\(deps(-dev)?\): bump|([A-Z]+-[0-9]+))\s+.+' | ||
| flags: 'gm' | ||
| error: 'Commit message must begin with a JIRA Issue Key: e.g. HP-123 <message>' |
There was a problem hiding this comment.
🟡 The commit-message-checker regex uses the gm flags, so ^ matches the start of any line rather than the true start of the message — a commit/PR title with no JIRA key still passes the check as long as any later body line happens to start with an approved token (e.g. HP-123 ... or even the word Merge). This weakens the CI gate described by the error message ("Commit message must begin with a JIRA Issue Key"); drop the m flag (or anchor to the start of the string) so ^ only matches the message's true beginning.
Extended reasoning...
The bug: .github/workflows/check-commit-message.yml runs gsactions/commit-message-checker@v2 with pattern: '^(Bump|Merge|Revert|Reapply|build\(deps(-dev)?\): bump|([A-Z]+-[0-9]+))\s+.+' and flags: 'gm'. The action's source does new RegExp(pattern, flags).test(message) against the full commit/PR message as a single multi-line string (subject + body concatenated). Because flags includes m (multiline), ^ matches the start of every line in that string, not just the true start of the message.
Code path: For pull_request events, the action builds message = title + '\\n\\n' + body; for push events it checks each commit's full subject+body. Either way, the regex/flag combination is applied to a multi-line string where ^/m lets any line — not just the first — satisfy the pattern.
Why nothing else prevents it: there is no separate per-line vs whole-string mode selection happening elsewhere in the workflow; the input (which would drop the body) is not set, so the full multi-line message is checked, and the flag is applied directly to that entire message.
Impact: A commit or PR title that does not begin with a JIRA key (or one of the approved prefixes) can still pass the check, as long as some later line in the body/trailers starts with an approved token. This directly contradicts the check's own error message: "Commit message must begin with a JIRA Issue Key." In practice this is easy to trigger by accident — e.g. a body that quotes or references another commit/PR title, or a trailer, could contain a line starting with Merge or a JIRA-style token — silently defeating the intended enforcement.
Step-by-step proof:
- Take pattern
'^(Bump|Merge|Revert|Reapply|build\(deps(-dev)?\): bump|([A-Z]+-[0-9]+))\s+.+'and flags'gm'. - Construct message
'fix a typo in readme\\n\\nHP-123 unrelated body text'— subject line has no JIRA key, but line 3 does. new RegExp(pattern, 'gm').test(message)→true(verified directly with node). The check passes even though the subject/title lacks a JIRA key.new RegExp(pattern, 'g').test(message)(droppingm) →false, correctly rejecting the message. This confirms themflag is the root cause.
Fix: Remove the m flag from flags: 'gm' (leaving just 'g', or whatever flags the action requires without multiline semantics), or anchor the pattern to the whole string (e.g. using \\A/lack of multiline so ^ binds to index 0 only). This restores the intended semantics: the message must begin with an approved token.
This is a real correctness bug in a CI policy gate that was synced from the org baseline (icanbwell/.github) as part of this PR, so it is in scope for review here even though fixing it locally would diverge from that baseline. It only produces false negatives (weakens enforcement) — it doesn't cause any runtime failure, crash, or data loss, so it does not need to block merge.
|
As a public repo, we're not merging anything about our stack or internal preferences with AI. closing PR. |
shawn-bwell
left a comment
There was a problem hiding this comment.
can't merge into public repo. and I somehow can't close this. Please close or revise the PR
8c0ee96 to
171b07b
Compare
Updates from icanbwell/.github: - AGENTS.md: Organization-wide AI agent instruction baseline - CLAUDE.md: Symlink for Claude Code compatibility - copilot-instructions.md: Lightweight instructions for GitHub Copilot - policies/approved-tech.yaml: Technology approval list - .github/workflows: PR architecture review and commit message validation - .claude/rules: Path-scoped Claude Code rules (OOAD/SOLID, testing, event contracts, operational) - CODEOWNERS: EA ownership of instruction files Source commit: b3dd8dad6e65c55f86b1766bc02590e41f9e6d59
171b07b to
86ad7da
Compare
|
Closing this. Org AI-agent standards now reach every Claude Code session through the b.well Claude org's managed settings, so the copied org instruction files are no longer needed and this sync is retired. If this repo still carries an org copy of |
Architecture Instruction File Sync
This PR updates the organization-wide AI agent instruction baseline files from
icanbwell/.github.Changes
Source commit: e161131768903dde30cced1ebf0cc7188509ed58
Review Notes
Review and merge when ready. These are org-wide architecture instruction updates from EA team. These files are purely additive and don't modify existing code.
Related: EA-2130