Skip to content

chore(deps): bump serde_with 3.20.0 → 3.21.0 in src-tauri#345

Merged
sonegillis1 merged 1 commit into
mainfrom
chore/bump-serde-with-3.21.0
Jul 16, 2026
Merged

chore(deps): bump serde_with 3.20.0 → 3.21.0 in src-tauri#345
sonegillis1 merged 1 commit into
mainfrom
chore/bump-serde-with-3.21.0

Conversation

@sonegillis1

Copy link
Copy Markdown
Contributor

What

Bumps serde_with 3.20.0 → 3.21.0 in src-tauri/Cargo.lock to clear the Dependabot alert (serde_with #243KeyValueMap serialization panics on an empty inner sequence/map entry; it subtracts 1 from the caller-visible length before validating a key field exists, so attacker-controlled data serialized through #[serde_as(as = "KeyValueMap<_>")] can crash the app).

Details

  • serde_with is a transitive dependency (not in Cargo.toml), so this is a lockfile-only change via cargo update -p serde_with --precise 3.21.0.
  • Also bumps serde_with_macros 3.20.0 → 3.21.0 and prunes three now-unused crates (windows-core/windows-result/windows-strings) — normal resolver cleanup.
  • Equivalent to the Dependabot PR; opened here so it's on a branch you control (merging either closes the alert).

Validated: cargo update resolved cleanly (semver-compatible) and a local cargo check on src-tauri compiles. Note the PR CI gate doesn't build Rust, so the Tauri build is validated on the next native build.

🤖 Generated with Claude Code

Fixes a Dependabot alert: KeyValueMap serialization in serde_with < 3.21.0
panics on an empty inner sequence/map entry (subtracts 1 from the length
before validating there is a key field). Transitive dep — lockfile-only bump
via `cargo update -p serde_with --precise 3.21.0` (also bumps
serde_with_macros and prunes three now-unused windows-* crates).
@sonegillis1
sonegillis1 requested a review from mamigot as a code owner July 16, 2026 09:40
@mamigot

mamigot commented Jul 16, 2026

Copy link
Copy Markdown
Member

Claude finished @sonegillis1's task —— View job


E2E Coverage Review

  • Dismiss stale REQUEST_CHANGES reviews
  • Identify changed files (CHANGELOG.md, src-tauri/Cargo.lock — no new routes)
  • Run mechanical coverage check (✅ 545 checkpoints, 100% coverage, exit code 0)
  • Applied CASE E: No new page.tsx files, coverage intact → Approved

@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ E2E Coverage — No Issues

No new app routes were introduced. All existing coverage is intact.

@sonegillis1
sonegillis1 merged commit ff738fe into main Jul 16, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants