Skip to content

fix(app): render LanguagePreferenceSync at the top of the provider tree#313

Open
sonegillis1 wants to merge 2 commits into
mainfrom
fix/app/hoist-language-preference-sync
Open

fix(app): render LanguagePreferenceSync at the top of the provider tree#313
sonegillis1 wants to merge 2 commits into
mainfrom
fix/app/hoist-language-preference-sync

Conversation

@sonegillis1

Copy link
Copy Markdown
Contributor

Summary

Move <LanguagePreferenceSync /> out of the AuthProvider subtree and render it at the top of the provider tree, alongside SentryInit / MentorTimeTrackingProvider.

Previously it only mounted when the AuthProviderTenantProvider subtree rendered (which is gated/skipped on SSO-login, version, and Tauri-offline routes). Hoisting it makes language-preference syncing mount regardless of that gating.

Change

   <SentryInit />
+  <LanguagePreferenceSync />
   <MentorTimeTrackingProvider intervalSeconds={30} enabled={true} />
   ...
-      <LanguagePreferenceSync />
       <TenantProvider ...>

One-line move; no behavior change beyond mount timing/placement.

Move <LanguagePreferenceSync /> out of the AuthProvider subtree and render it
alongside SentryInit / MentorTimeTrackingProvider at the top level, so it mounts
regardless of the AuthProvider/TenantProvider gating instead of only when that
subtree renders.
@sonegillis1
sonegillis1 requested a review from mamigot as a code owner July 6, 2026 23:46
@mamigot

mamigot commented Jul 6, 2026

Copy link
Copy Markdown
Member

Claude finished @sonegillis1's task —— View job


E2E Coverage Review

  • Dismiss stale REQUEST_CHANGES reviews (none found)
  • Identify changed files (providers/index.tsx only — no new page.tsx routes)
  • Run mechanical coverage check (499 checkpoints, exit code 0)
  • Apply decision logic and post review (Case E: approved)

Result: No new app routes were introduced. All existing coverage is intact. PR approved. ✅

@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ E2E Coverage — No Issues

No new app routes were introduced. All existing coverage is intact.

@mamigot

mamigot commented Jul 13, 2026

Copy link
Copy Markdown
Member

Claude finished @sonegillis1's task —— View job


E2E Coverage Review

  • Dismiss stale REQUEST_CHANGES reviews (none found)
  • Identify changed files (providers/index.tsx only — no new page.tsx routes)
  • Run mechanical coverage check (545 checkpoints, exit code 0)
  • Apply decision logic and post review (Case E: approved)

Result: No new app routes were introduced. All existing coverage is intact. PR approved. ✅

View job

@sonegillis1 sonegillis1 added the run-tests Trigger PR validation pipeline label Jul 13, 2026

@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ E2E Coverage — No Issues

No new app routes were introduced. All existing coverage is intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-tests Trigger PR validation pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants