fix(assign): preserve input coercion when merging structs#1300
Open
xianjianlf2 wants to merge 1 commit into
Open
fix(assign): preserve input coercion when merging structs#1300xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
`assign` rebuilt the merged struct via `object()`/`type()` from the combined schemas, discarding any top-level coercer the input structs carried (e.g. `defaulted`, `trimmed`). As a result, wrapping a struct with `defaulted` and then passing it to `assign` silently dropped the default values during `create`. Compose the inputs' coercers into the merged struct's coercer. The merged struct's own coercer still runs last so masking is applied once against the combined schema, and the inputs run with masking disabled so they don't strip keys owned by the other structs being assigned. Closes ianstormtaylor#791
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
assignrebuilt the merged struct viaobject()/type()from the combined schemas, discarding any top-level coercer the input structs carried (e.g.defaulted,trimmed). As a result, wrapping a struct withdefaultedand then passing it toassignsilently dropped the default values duringcreate.Fix
Compose the inputs' coercers into the merged struct's coercer. The merged struct's own coercer still runs last so masking is applied once against the combined schema, and the inputs run with masking disabled so they don't strip keys owned by the other structs being assigned.
Testing
Added
test/validation/assign/coerce-defaulted.ts, which exercisescreateon anassign-merged struct wrapped withdefaultedand asserts the default values are preserved.Closes #791