Version v2.0.0 by ianpaschal · Pull Request #9 · ianpaschal/combat-command-game-systems

ianpaschal · 2026-07-16T06:45:28Z

Branch Overview: `v2` vs `main` — `combat-command-game-systems`

Scope: 105 files changed, 2,273 insertions / 1,418 deletions. This is the published npm package (@ianpaschal/combat-command-game-systems) consumed by combat-command. Unlike the main app repo, this package has real external consumers, so its API changes are genuinely breaking.

Conceptual shift: Mirrors the combat-command frontend change — removes registration-level detail schemas entirely, reworks listData validation from a Zod-schema-factory model to a plain async validate() function, and splits static data files into data-only modules plus companion .helpers.ts files.

1. `ListData` Schema and Validators

src/battlefront/_shared/schema/listData.ts: 100 → 60 lines. src/battlefront/_shared/schema/listData.validators.ts: 253 → 400+ lines.

Breaking API change:

Old: createListDataSchema() factory returning a Zod schema. Consumers called listData.schema.safeParse(data) or listData.createSchema(options).safeParse(data). Types: GenericListData, CreateListDataSchemaContext, CreateListDataSchemaOptions.
New: validateListDataShape(data: ListDataShape, context: ListDataContext, options?: ListDataOptions) => ValidationIssue[]. Consumers now call await listData.validate(data, options) at the game-system level, returning ValidateListDataResult<T> = { success: true; data: T } | { success: false; issues: ValidationIssue[] }.
New exported types: ListDataContext, ListDataOptions, ListDataShape.
Per game system (e.g. flamesOfWarV4/schema/listData.ts): listData.schema and listData.createSchema() removed; listData.validate(), listData.defaultValues, listData.getDefaultValues(config) added. ListData/ListDataFormData types are now more concrete (e.g. era: Era instead of optional, sourceId: Unit instead of Zod-inferred).
greatWarV4/schema/listData.ts initially shipped without getDefaultValues(), unlike flamesOfWarV4/teamYankeeV2. Added for symmetry, plus matching test coverage (.getDefaultValues describe block, and the "not a valid unit ID" checks on formations/units that greatWarV4 — like flamesOfWarV4 — can enforce via its real Unit enum).

2. `registrationDetails` Removal

Deleted:

src/battlefront/_shared/schema/registrationDetails.ts (47 lines)
src/battlefront/flamesOfWarV4/schema/registrationDetails.ts + test
src/battlefront/teamYankeeV2/schema/registrationDetails.ts + test
(greatWarV4 never had one)

Deprecated helpers deleted (per flamesOfWarV4 and teamYankeeV2 — already @deprecated on main):

getValidGameSystemConfig.ts, getValidMatchResultDetails.ts, isGameSystemConfigValid.ts, isMatchResultDetailsValid.ts

Root export removed: src/battlefront/index.ts drops export * from './_shared/schema/registrationDetails'.

No replacement — this functionality is fully retired, not relocated.

3. Static Data Files → `.helpers.ts` Pattern

All game-system static data files (alignments, eras, factions, forceDiagrams, units, dynamicPointsVersions, series, missionPackVersions, etc.) split into a data-only .ts file plus a companion .helpers.ts file.

Example — flamesOfWarV4/static/factions.ts:

Old: single 115-line file exporting the Faction enum, factions record, and helpers (getFactionOptions(), getFactionDisplayName()).
New: factions.ts (20 lines, enum + record only) + factions.helpers.ts (85 lines, all helpers).
- getFactionOptions() signature changed: now takes GetFactionOptionsFilters (alignment?, era?).
- New: getFactionDisplayAdjective(key?), getFactionAlignment(key, era).
- Data shape change: alignment is now Partial<Record<Era, Alignment>> instead of a single value.

Example — dynamicPointsVersions.ts: data (65 lines) split from helpers (dynamicPointsVersions.helpers.ts, 23 lines) — getDynamicPointsVersionOptions(), getDynamicPointsVersionDisplayName() moved out.

Breaking import paths:

// Old
import { getFactionOptions } from '@ianpaschal/combat-command-game-systems/flamesOfWarV4/static/factions'
// New (direct)
import { getFactionOptions } from '@ianpaschal/combat-command-game-systems/flamesOfWarV4/static/factions.helpers'

Each game-system index.ts now re-exports all .helpers modules, so importing from the game-system root (.../flamesOfWarV4) still works — only direct submodule imports break.

4. New `getListDisplayName` Helper

Added per game system, each with a test:

flamesOfWarV4/helpers/getListDisplayName.ts (+ test, 60 lines)
greatWarV4/helpers/getListDisplayName.ts (+ test, 56 lines)
teamYankeeV2/helpers/getListDisplayName.ts (+ test, 60 lines)

export const getListDisplayName = (listData?: Partial): string

Falls back in order: force diagram → faction → alignment → "Unknown", appending " Force". e.g. getListDisplayName({ meta: { forceDiagram: ForceDiagram.DDayBritish } }) → 'D-Day: British Force'. Exported from each game-system index.ts.

5. Root `src/battlefront/index.ts`

Single line removed: export * from './_shared/schema/registrationDetails';. Nothing else changed at this entry point.

6. `src/common/schemas/listDataId.ts` and `src/common/types.ts`

listDataId.ts — breaking change:

// Old
export const listDataId = (options?: {...}): z.ZodString => z.string(...).regex(...)
export type ListDataId = z.infer<ReturnType<typeof listDataId>>

// New
export type ListDataId = string
export const isListDataId = (value: unknown): value is ListDataId =>
  typeof value === 'string' && /^[0-9a-z]{6}$/.test(value)

Consumers importing listDataId as a Zod schema factory will break — it's now a type + type guard.

types.ts — additions:

export type ValidationIssue = { path: (string | number)[]; message: string };
export type ValidateListDataResult<T> =
  | { success: true; data: T }
  | { success: false; issues: ValidationIssue[] };

7. `commandCard.ts`, `formation.ts`, `unit.ts` Deletions

All three Zod schema factories deleted:

commandCard.ts (9 lines) — was export const commandCard = z.object({ id: listDataId(), sourceId: z.string(), appliedTo: listDataId() })
formation.ts (13 lines) — was export const createFormationSchema = <T>(sourceId: T) => z.object({...})
unit.ts (13 lines) — was export const createUnitSchema = <T>(sourceId: T) => z.object({...})

Replaced implicitly by the ListDataShape structural type in listData.validators.ts — no schema-factory equivalent remains.

_shared/types.ts changes:

AlignmentMetadata gains displayAdjective: string, displayPlural: string.
FactionMetadata<TAlignment> and ForceDiagramMetadata<TFaction, TSeries> removed from shared types, moved to per-game-system types.ts with different shapes:
- flamesOfWarV4/teamYankeeV2: FactionMetadata<TEra, TAlignment>, era-aware (alignment: Partial<Record<TEra, TAlignment>>).
- greatWarV4: FactionMetadata<TAlignment>, single value, no era dimension.

8. Dependencies

package.json: no version or dependency changes.
package-lock.json: adds lodash@^4.18.1 (runtime) and @types/lodash@^4.17.24 (dev) — confirmed in use, via getDefaultValues() in each game system's listData.ts (flamesOfWarV4, teamYankeeV2, greatWarV4).
src/common/_internal/emptyToUndefined.ts deleted (5 lines) — a Zod-specific transformer no longer needed.

Fixed: those three listData.ts files originally imported lodash as import { merge } from 'lodash'. lodash is CommonJS, and that named-import syntax only resolves under bundlers (Vite, webpack) that shim CJS/ESM interop — it fails under Node's native ESM loader or any consumer that skips transforming node_modules (e.g. combat-command's vitest project for convex/**, which runs edge-runtime with external: ['**/node_modules/**']). Since this package ships its build output directly to consumers without bundling dependencies, that failure surfaced downstream, not in this repo's own tests. Changed to import lodash from 'lodash' + lodash.merge(...), which works under both bundled and native-ESM consumption. No behavioral change — same function reference either way.

Breaking Changes for Consumers

listData validation API replaced. schema.safeParse() / createSchema() are gone; consumers must switch to await listData.validate(data, options) returning { success, data | issues } instead of Zod's SafeParseReturnType.
Static-data helper import paths changed. Direct imports like .../static/factions no longer export helper functions — they're in .../static/factions.helpers (or via the game-system's root index, which still re-exports everything).
registrationDetails schemas and deprecated helpers fully removed (getValidGameSystemConfig, getValidMatchResultDetails, isGameSystemConfigValid, isMatchResultDetailsValid) — no replacement, by design.
Schema factories commandCard, createFormationSchema, createUnitSchema deleted — any direct import breaks.
listDataId is no longer a Zod schema factory — it's now type ListDataId = string plus isListDataId() type guard.
FactionMetadata / ForceDiagramMetadata shape changed and relocated out of shared types into per-game-system types, with flamesOfWarV4/teamYankeeV2 now keying faction alignment by era (greatWarV4 unaffected on this dimension since it has no eras).

This lines up with (and is the underlying dependency for) the breaking changes found in the combat-command app branch — that repo's package.json currently points at a local file: tarball of this package rather than a published version, so these two branches need to land together.

Summary by CodeRabbit

New Features
- Added clearer list validation with actionable messages for metadata, units, formations, command cards, duplicates, and legality.
- Added filtered selection options and display-name helpers for factions, force diagrams, eras, series, units, missions, and publication versions.
- Added automatic list display names with fallback from force diagram to faction, alignment, or “Unknown Force.”
- Added list default values populated from game configuration.
Bug Fixes
- Corrected Bulge force diagram names previously displayed as Berlin.

coderabbitai · 2026-07-16T06:45:37Z

Walkthrough

The change replaces Zod-based list-data schemas with explicit TypeScript validation and structured validation results. Shared validators now collect issues, while Flames of War V4, Great War V4, and Team Yankee V2 expose validation and default-value APIs. Static metadata gains display fields and era-aware mappings, with option and display helpers moved into dedicated modules. List display-name helpers, barrel exports, tests, spelling configuration, and coverage settings are also updated.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is too generic and does not describe the actual breaking API changes in this pull request.	Use a concise title that names the main change, such as removing schema factories and moving to validate() helpers for version 2.0.0.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-07-16T06:47:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

coderabbitai

Actionable comments posted: 11

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/battlefront/_shared/schema/listData.validators.ts (1)
90-104: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Use own-property checks for static-data keys.

The in operator accepts inherited names such as toString and constructor. For example, an optional forceDiagram: "toString" can be treated as recognized and produce no issue. Replace every listed membership check with a shared own-property check.

Also applies to: 133-135, 169-170, 214-216, 332-349, 440-457
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/battlefront/_shared/schema/listData.validators.ts` around lines 90 - 104,
Replace every static-data membership test in listData.validators.ts, including
the checks near the force diagram, faction, unit, and related validation blocks,
with the shared own-property check. Ensure inherited keys such as toString and
constructor are rejected while valid own keys retain the existing validation
behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/battlefront/_shared/schema/listData.ts`:
- Around line 25-64: Update validateListDataShape and each public
validate(rawFormData: unknown) entry point to perform shared runtime structural
validation before casting, normalization, metadata checks, or iterating
formations, units, and commandCards. Reject null and objects missing meta or
required array fields by returning { success: false, issues } instead of
dereferencing them, while preserving existing cross-field validation for
structurally valid data; add malformed-input tests.

In `@src/battlefront/flamesOfWarV4/schema/listData.ts`:
- Around line 64-96: Make validate safely handle malformed rawFormData before
accessing formData.meta or iterating formData.units. Replace the unsafe
cast-only flow with structural guards or the existing schema validation so null,
undefined, and missing nested properties produce ValidationIssue results rather
than throwing; preserve normal normalization, slot validation, and points-limit
validation for valid ListDataFormData.

In `@src/battlefront/flamesOfWarV4/static/factions.helpers.ts`:
- Around line 15-61: Normalize nullable era and alignment filters to undefined
at the start of getFactionOptions, and return all faction entries when neither
normalized filter is active, including for an empty object. Update
getForceDiagramOptions in
src/battlefront/flamesOfWarV4/static/forceDiagrams.helpers.ts (lines 9-35) to
use nullish checks for every optional filter, then add regression coverage for
empty and nullable filter objects in both helpers.

In `@src/battlefront/greatWarV4/schema/listData.ts`:
- Around line 56-87: Update validate to defensively read the unknown rawFormData
structure before accessing nested fields: use safe optional access for
formData.meta values and provide an empty-array fallback when iterating
formData.units. Preserve the existing validation and successful data
construction behavior for complete payloads while preventing malformed or
incomplete input from throwing runtime TypeErrors.

In `@src/battlefront/greatWarV4/static/factions.helpers.ts`:
- Around line 1-19: Update getFactionDisplayAdjective to use the shared
getDisplayAdjective utility, matching the pattern used by companion helpers such
as the alignment helpers. Import the utility from the common internal helpers
and pass factions and the requested key through it, removing the manual presence
check and direct lookup.

In `@src/battlefront/teamYankeeV2/schema/listData.ts`:
- Around line 64-78: Update validate to check and normalize rawFormData before
accessing formData.meta or iterating formData.units; handle undefined, objects
without required arrays, and other malformed roots by returning a structured
ValidateListDataResult containing validation issues instead of throwing. Only
call validateListDataShape and continue unit validation after the root shape is
confirmed valid.
- Around line 98-110: Update getDefaultValues to deep-copy the collection fields
formations, units, and commandCards when constructing each result, rather than
reusing references from defaultValues. Preserve the existing scalar and meta
defaults while ensuring every caller receives independent collections that
cannot mutate shared defaults.

In `@src/battlefront/teamYankeeV2/static/factions.helpers.ts`:
- Around line 39-44: Update the filter checks in the faction filtering logic to
treat both null and undefined as unset: only compare era when filters.era is
non-null, and only compare alignment when filters.alignment is non-null.
Preserve the existing comparisons and return behavior for provided values.

In `@src/battlefront/teamYankeeV2/static/forceDiagrams.helpers.ts`:
- Around line 16-30: Update the filtering conditions in getForceDiagramOptions
so nullable filter values are treated as unset, matching the filter contract.
Adjust the faction, alignment, series, and era checks to skip filtering when
their corresponding value is null or undefined, while preserving existing
filtering for defined non-null values.

In `@src/battlefront/teamYankeeV2/static/forceDiagrams.test.ts`:
- Around line 61-69: Extend the combined filters test around
getForceDiagramOptions to include the era filter, asserting every returned
diagram belongs to the requested era. Also cover an era with no matching
diagrams by asserting the result is empty, using the existing era and
force-diagram symbols.

In `@src/common/_internal/getDisplayAdjective.ts`:
- Around line 8-9: Update the lookup in getDisplayAdjective to access
items[search] directly instead of creating and scanning Object.entries(items).
Preserve returning the matched entry’s displayAdjective, or undefined when no
value exists.

---

Outside diff comments:
In `@src/battlefront/_shared/schema/listData.validators.ts`:
- Around line 90-104: Replace every static-data membership test in
listData.validators.ts, including the checks near the force diagram, faction,
unit, and related validation blocks, with the shared own-property check. Ensure
inherited keys such as toString and constructor are rejected while valid own
keys retain the existing validation behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 804b85aa-3c12-4581-be4d-988ce874b0c4

📥 Commits

Reviewing files that changed from the base of the PR and between 6d8a3c4 and e5f4a8e.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (108)

.vscode/settings.json
src/battlefront/_shared/_fixtures/getIssueMessages.test.ts
src/battlefront/_shared/_fixtures/getIssueMessages.ts
src/battlefront/_shared/_fixtures/validateOptionSet.ts
src/battlefront/_shared/_internal/createGetForceDiagramData.ts
src/battlefront/_shared/_internal/createGetListDisplayName.ts
src/battlefront/_shared/schema/commandCard.ts
src/battlefront/_shared/schema/formation.ts
src/battlefront/_shared/schema/listData.test.ts
src/battlefront/_shared/schema/listData.ts
src/battlefront/_shared/schema/listData.validators.ts
src/battlefront/_shared/schema/registrationDetails.test.ts
src/battlefront/_shared/schema/registrationDetails.ts
src/battlefront/_shared/schema/unit.ts
src/battlefront/_shared/types.ts
src/battlefront/flamesOfWarV4/helpers/getListDisplayName.test.ts
src/battlefront/flamesOfWarV4/helpers/getListDisplayName.ts
src/battlefront/flamesOfWarV4/helpers/getValidGameSystemConfig.ts
src/battlefront/flamesOfWarV4/helpers/getValidMatchResultDetails.ts
src/battlefront/flamesOfWarV4/helpers/isGameSystemConfigValid.ts
src/battlefront/flamesOfWarV4/helpers/isMatchResultDetailsValid.ts
src/battlefront/flamesOfWarV4/index.ts
src/battlefront/flamesOfWarV4/schema/listData.test.ts
src/battlefront/flamesOfWarV4/schema/listData.ts
src/battlefront/flamesOfWarV4/schema/registrationDetails.test.ts
src/battlefront/flamesOfWarV4/schema/registrationDetails.ts
src/battlefront/flamesOfWarV4/static/alignments.helpers.ts
src/battlefront/flamesOfWarV4/static/alignments.ts
src/battlefront/flamesOfWarV4/static/dynamicPointsVersions.helpers.ts
src/battlefront/flamesOfWarV4/static/dynamicPointsVersions.ts
src/battlefront/flamesOfWarV4/static/eras.helpers.ts
src/battlefront/flamesOfWarV4/static/eras.ts
src/battlefront/flamesOfWarV4/static/factions.helpers.ts
src/battlefront/flamesOfWarV4/static/factions.ts
src/battlefront/flamesOfWarV4/static/forceDiagrams.helpers.ts
src/battlefront/flamesOfWarV4/static/forceDiagrams.test.ts
src/battlefront/flamesOfWarV4/static/forceDiagrams.ts
src/battlefront/flamesOfWarV4/static/lessonsFromTheFrontVersions.helpers.ts
src/battlefront/flamesOfWarV4/static/lessonsFromTheFrontVersions.ts
src/battlefront/flamesOfWarV4/static/missionPackVersions.helpers.ts
src/battlefront/flamesOfWarV4/static/missionPackVersions.ts
src/battlefront/flamesOfWarV4/static/series.helpers.ts
src/battlefront/flamesOfWarV4/static/series.ts
src/battlefront/flamesOfWarV4/static/units.helpers.ts
src/battlefront/flamesOfWarV4/static/units.ts
src/battlefront/flamesOfWarV4/types.ts
src/battlefront/greatWarV4/helpers/getListDisplayName.test.ts
src/battlefront/greatWarV4/helpers/getListDisplayName.ts
src/battlefront/greatWarV4/index.ts
src/battlefront/greatWarV4/schema/listData.test.ts
src/battlefront/greatWarV4/schema/listData.ts
src/battlefront/greatWarV4/static/alignments.helpers.ts
src/battlefront/greatWarV4/static/alignments.ts
src/battlefront/greatWarV4/static/factions.helpers.ts
src/battlefront/greatWarV4/static/factions.ts
src/battlefront/greatWarV4/static/forceDiagrams.helpers.ts
src/battlefront/greatWarV4/static/forceDiagrams.test.ts
src/battlefront/greatWarV4/static/forceDiagrams.ts
src/battlefront/greatWarV4/static/missionNames.helpers.ts
src/battlefront/greatWarV4/static/missionNames.ts
src/battlefront/greatWarV4/static/missionPackUtils.ts
src/battlefront/greatWarV4/static/missionPackVersions.helpers.ts
src/battlefront/greatWarV4/static/missionPackVersions.ts
src/battlefront/greatWarV4/static/pointsVersions.helpers.ts
src/battlefront/greatWarV4/static/pointsVersions.ts
src/battlefront/greatWarV4/static/units.helpers.ts
src/battlefront/greatWarV4/static/units.ts
src/battlefront/greatWarV4/types.ts
src/battlefront/index.ts
src/battlefront/teamYankeeV2/helpers/getListDisplayName.test.ts
src/battlefront/teamYankeeV2/helpers/getListDisplayName.ts
src/battlefront/teamYankeeV2/helpers/getValidGameSystemConfig.ts
src/battlefront/teamYankeeV2/helpers/getValidMatchResultDetails.ts
src/battlefront/teamYankeeV2/helpers/isGameSystemConfigValid.ts
src/battlefront/teamYankeeV2/helpers/isMatchResultDetailsValid.ts
src/battlefront/teamYankeeV2/index.ts
src/battlefront/teamYankeeV2/schema/listData.test.ts
src/battlefront/teamYankeeV2/schema/listData.ts
src/battlefront/teamYankeeV2/schema/registrationDetails.test.ts
src/battlefront/teamYankeeV2/schema/registrationDetails.ts
src/battlefront/teamYankeeV2/static/alignments.helpers.ts
src/battlefront/teamYankeeV2/static/alignments.ts
src/battlefront/teamYankeeV2/static/dynamicPointsVersions.helpers.ts
src/battlefront/teamYankeeV2/static/dynamicPointsVersions.ts
src/battlefront/teamYankeeV2/static/eras.helpers.ts
src/battlefront/teamYankeeV2/static/eras.ts
src/battlefront/teamYankeeV2/static/factions.helpers.ts
src/battlefront/teamYankeeV2/static/factions.ts
src/battlefront/teamYankeeV2/static/fieldManual101Versions.helpers.ts
src/battlefront/teamYankeeV2/static/fieldManual101Versions.ts
src/battlefront/teamYankeeV2/static/forceDiagrams.helpers.ts
src/battlefront/teamYankeeV2/static/forceDiagrams.test.ts
src/battlefront/teamYankeeV2/static/forceDiagrams.ts
src/battlefront/teamYankeeV2/static/missionPackVersions.helpers.ts
src/battlefront/teamYankeeV2/static/missionPackVersions.ts
src/battlefront/teamYankeeV2/static/series.helpers.ts
src/battlefront/teamYankeeV2/static/series.ts
src/battlefront/teamYankeeV2/static/units.helpers.ts
src/battlefront/teamYankeeV2/static/units.ts
src/battlefront/teamYankeeV2/types.ts
src/common/_internal/createEnumSchema.test.ts
src/common/_internal/emptyToUndefined.ts
src/common/_internal/getDisplayAdjective.test.ts
src/common/_internal/getDisplayAdjective.ts
src/common/_internal/index.ts
src/common/schemas/listDataId.ts
src/common/types.ts
vitest.config.ts

💤 Files with no reviewable changes (37)

src/battlefront/_shared/schema/commandCard.ts
src/common/_internal/emptyToUndefined.ts
src/battlefront/_shared/_internal/createGetForceDiagramData.ts
src/battlefront/teamYankeeV2/helpers/isGameSystemConfigValid.ts
src/battlefront/flamesOfWarV4/schema/registrationDetails.test.ts
src/battlefront/_shared/schema/formation.ts
src/battlefront/flamesOfWarV4/schema/registrationDetails.ts
src/battlefront/flamesOfWarV4/helpers/getValidGameSystemConfig.ts
src/battlefront/flamesOfWarV4/helpers/isGameSystemConfigValid.ts
src/battlefront/teamYankeeV2/helpers/isMatchResultDetailsValid.ts
src/battlefront/teamYankeeV2/schema/registrationDetails.ts
src/battlefront/teamYankeeV2/static/eras.ts
src/battlefront/greatWarV4/static/missionPackVersions.ts
src/battlefront/_shared/schema/registrationDetails.ts
src/battlefront/flamesOfWarV4/helpers/getValidMatchResultDetails.ts
src/battlefront/teamYankeeV2/schema/registrationDetails.test.ts
src/battlefront/teamYankeeV2/helpers/getValidGameSystemConfig.ts
src/battlefront/index.ts
src/battlefront/flamesOfWarV4/static/lessonsFromTheFrontVersions.ts
src/battlefront/_shared/schema/unit.ts
src/battlefront/teamYankeeV2/helpers/getValidMatchResultDetails.ts
src/battlefront/_shared/schema/registrationDetails.test.ts
src/battlefront/flamesOfWarV4/helpers/isMatchResultDetailsValid.ts
src/battlefront/flamesOfWarV4/static/dynamicPointsVersions.ts
src/battlefront/teamYankeeV2/static/series.ts
vitest.config.ts
src/battlefront/teamYankeeV2/static/fieldManual101Versions.ts
src/battlefront/flamesOfWarV4/static/series.ts
src/battlefront/teamYankeeV2/static/missionPackVersions.ts
src/battlefront/flamesOfWarV4/static/units.ts
src/battlefront/flamesOfWarV4/static/missionPackVersions.ts
src/battlefront/teamYankeeV2/static/units.ts
src/battlefront/greatWarV4/static/units.ts
src/battlefront/teamYankeeV2/static/dynamicPointsVersions.ts
src/battlefront/flamesOfWarV4/static/eras.ts
src/battlefront/greatWarV4/static/pointsVersions.ts
src/battlefront/greatWarV4/static/missionNames.ts

coderabbitai

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/battlefront/_shared/helpers/validateListData.ts`:
- Around line 64-87: Update validateListData so formations, units, and
commandCards each produce structural validation issues when their corresponding
values are not arrays, rather than silently iterating an empty list. Preserve
normal validation for array values and keep requireLegal limited to legality
checks; update the affected expectation in validateListData tests so incomplete
data no longer returns success.

In `@src/battlefront/_shared/helpers/validateListData.validators.ts`:
- Line 80: Replace the inherited-property check in the relevant validators,
including the condition near value metadata recognition, with an own-property
predicate on the corresponding context map. Apply this consistently at all
indicated checks so keys such as constructor and toString are not accepted as
valid faction, alignment, era, force-diagram, or unit metadata.
- Around line 322-326: Update the validation checks using getValue in
validateListData so slotId, command-card sourceId, and formation/unit sourceId
are accepted only when their values are strings (while preserving required-value
checks). Ensure source-key validation runs even when context.units is empty, so
truthy objects or numbers cannot produce a successful result.

In `@src/battlefront/_shared/types.ts`:
- Around line 28-35: Constrain the TSourceId generic in both ListDataFormation
and ListDataUnit to string so their sourceId fields match the string-keyed
contracts enforced by validateFormation and validateUnit. Preserve the existing
type shapes and identifiers while adding the shared string constraint.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b53a5e4e-63cb-410a-b97c-313511310392

📥 Commits

Reviewing files that changed from the base of the PR and between e5f4a8e and 75383d1.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (21)

package.json
src/battlefront/_shared/helpers/validateListData.test.ts
src/battlefront/_shared/helpers/validateListData.ts
src/battlefront/_shared/helpers/validateListData.validators.ts
src/battlefront/_shared/schema/listData.ts
src/battlefront/_shared/types.ts
src/battlefront/flamesOfWarV4/schema/listData.ts
src/battlefront/flamesOfWarV4/static/factions.helpers.ts
src/battlefront/flamesOfWarV4/static/factions.test.ts
src/battlefront/flamesOfWarV4/static/forceDiagrams.helpers.ts
src/battlefront/flamesOfWarV4/static/forceDiagrams.test.ts
src/battlefront/greatWarV4/schema/listData.ts
src/battlefront/greatWarV4/static/factions.helpers.ts
src/battlefront/teamYankeeV2/schema/listData.ts
src/battlefront/teamYankeeV2/static/factions.helpers.ts
src/battlefront/teamYankeeV2/static/forceDiagrams.helpers.ts
src/battlefront/teamYankeeV2/static/forceDiagrams.test.ts
src/common/_internal/getDisplayAdjective.ts
src/common/_internal/getValue.test.ts
src/common/_internal/getValue.ts
src/common/_internal/index.ts

💤 Files with no reviewable changes (1)

src/battlefront/_shared/schema/listData.ts

ianpaschal added 4 commits June 16, 2026 15:14

WIP

cdb4e20

WIP

6eaa315

WIP

c5a43a1

WIP

d2a5ad2

PR Feedback

e5f4a8e

coderabbitai Bot reviewed Jul 17, 2026

View reviewed changes

PR Feedback

75383d1

coderabbitai Bot reviewed Jul 18, 2026

View reviewed changes

Comment thread src/battlefront/_shared/helpers/validateListData.ts

Comment thread src/battlefront/_shared/helpers/validateListData.validators.ts Outdated

Comment thread src/battlefront/_shared/helpers/validateListData.validators.ts Outdated

Comment thread src/battlefront/_shared/types.ts Outdated

ianpaschal added 3 commits July 18, 2026 14:31

PR Feedback

da5aa3a

2.0.0

dde4a92

Fix lodash module resolution

e869091

ianpaschal merged commit 565b568 into main Jul 19, 2026
5 checks passed

ianpaschal deleted the v2 branch July 19, 2026 08:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version v2.0.0#9

Version v2.0.0#9
ianpaschal merged 9 commits into
mainfrom
v2

ianpaschal commented Jul 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 16, 2026 •

edited

Loading

❌ Failed checks (1 inconclusive)

Uh oh!

codecov Bot commented Jul 16, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ianpaschal commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Branch Overview: v2 vs main — combat-command-game-systems

1. ListData Schema and Validators

2. registrationDetails Removal

3. Static Data Files → .helpers.ts Pattern

4. New getListDisplayName Helper

5. Root src/battlefront/index.ts

6. src/common/schemas/listDataId.ts and src/common/types.ts

7. commandCard.ts, formation.ts, unit.ts Deletions

8. Dependencies

Breaking Changes for Consumers

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

❌ Failed checks (1 inconclusive)

Uh oh!

codecov Bot commented Jul 16, 2026

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ianpaschal commented Jul 16, 2026 •

edited

Loading

Branch Overview: `v2` vs `main` — `combat-command-game-systems`

1. `ListData` Schema and Validators

2. `registrationDetails` Removal

3. Static Data Files → `.helpers.ts` Pattern

4. New `getListDisplayName` Helper

5. Root `src/battlefront/index.ts`

6. `src/common/schemas/listDataId.ts` and `src/common/types.ts`

7. `commandCard.ts`, `formation.ts`, `unit.ts` Deletions

coderabbitai Bot commented Jul 16, 2026 •

edited

Loading