fix(conversation): upsert streaming tool calls (AIO-30)#484
Open
TCP404 wants to merge 1 commit into
Open
Conversation
- Persist ACP and aionrs tool-call events through an atomic message upsert - Merge JSON content on duplicate message IDs while preserving terminal status - Cover out-of-order ACP and aionrs tool-call event persistence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multica issue: AIO-30
Root Cause
Streaming tool-call persistence used separate read/update/insert branches. Concurrent or out-of-order events for the same message ID could either hit a duplicate primary key error or lose fields when an update arrived before the initial insert.
Changes
messages.idconflicts.INSERT ... ON CONFLICT(id) DO UPDATEwith JSON merge semantics.finish/errorstatus when lateworkevents arrive.Verification
cargo test -p aionui-dbcargo test -p aionui-conversationcargo clippy -p aionui-db -- -D warningscargo clippy -p aionui-conversation -- -D warnings