Skip to content

Focus new tabs immediately and expand Chrome controls with private browser features - #6

Merged
iMumd merged 3 commits into
mainfrom
feat/private-browser-shortcut-coverage
Nov 1, 2026
Merged

iMumd merged 3 commits into
mainfrom
feat/private-browser-shortcut-coverage

Conversation

@iMumd

@iMumd iMumd commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Confirmed scope

The owner selected the top address bar for new-tab focus and requested both broader Chrome shortcut coverage and the missing underlying browser features. This PR adds 66 configurable actions plus aliases, checked against Chrome's desktop shortcut reference, without pretending that Fathi implements every Chrome service/feature.

New-tab focus

Focus the top address/search bar BEFORE asynchronous session/proxy preparation, preserve text typed during that preparation, recognize explicit fathi://newtab URLs, and dismiss foreground panels that would cover the field. Background creation still does not steal focus. Real native clicks on both new-tab buttons are tested, not just programmatic creation.

Actual new features

  • Ctrl+N / Ctrl+Shift+N launch actual independent private window processes, with fresh tab/session/fingerprint maps and temporary directories. All Fathi windows are private; no persistent normal mode is introduced.
  • Session bookmarks and bookmark-all, bar/manager/removal, session history, tab search and process CPU/memory metrics.
  • Native download tracking/progress, active pause/resume/cancel, completed-file reveal and explicit save-copy. Unique temporary filenames prevent collisions/path traversal. No automatic execution.
  • Explicit session-data clearing: shortcut opens options, a separate button clears actual history/cookies/storage/auth/cache for this window, retaining bookmarks.
  • Actual Chromium source viewing in a fresh isolated tab, page inspection, local-file picker, tab reordering, search/toolbar/dialog/bookmark focus, menu keyboard navigation, Alt+Enter navigation, native print aliases, and macOS/non-Latin layout safeguards.
  • One-time migration of known shipped legacy defaults frees Ctrl+D for bookmarks and Ctrl+Shift+P for printing without overwriting distinct custom bindings or claimed target combinations.

Privacy and boundaries

Bookmarks (200), history (300), closed URLs (10) and download records (100) are session-only. Browsing records never enter settings. Downloads remain in the existing temporary storage unless explicitly exported. IPC actions require browser-chrome ownership; file actions do not accept arbitrary paths from page content.

Independent window processes intentionally do not live-sync settings, transfer tabs or quit each other. Task metrics are read-only. Google accounts/sync/password management, tab groups, split view, caret-browsing controls and address predictions are not implemented or mapped to unrelated actions. Source viewing uses a new identity, so authenticated source may require sign-in. Native print/file dialogs and packaged platform-specific behavior still require manual checks. These differences are prominent in docs/keyboard-shortcuts.md; this is NOT a false claim of complete Chrome parity.

Validation

  • npm test: 44 tests plus rule-worker checks pass locally; 58 JS files syntax checked.
  • Full real application audit: 108/108 checks passed with exit code 0. Includes keyboard/mouse focus, preserved immediate typing, real additional Ctrl+N/Ctrl+Shift+N processes with readiness acknowledgements and fresh partitions, bookmarks and escaped titles, history, task metrics, actual completed local download, Chromium source, real cookie/storage clearing, tab movement, Alt+Enter and toolbar focus. Existing identity/storage/worker/interception/rule checks remain.
  • Window-launch test children use isolated temporary test configuration and are cleaned up; production windows do not inherit the audit marker or ELECTRON_RUN_AS_NODE.
  • Relative documentation links resolve; no private tooling or browsing captures are tracked. All CI must pass before merge. Self-review, not independent approval.

Three focused commits. Version remains 1.0.2. No release/assets or updater metadata/blockmap changes, and default proxy pool remains empty.

@iMumd

iMumd commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

Self-review complete (not independent approval). CI run 41260382162 passed Windows, Linux and macOS. Inspected the Windows job log and confirmed 108/108 application checks and E2E_OK, including actual additional browser processes, focus, native input, download and storage-clear cases. Local npm test passed 44 tests plus worker checks; 58 JS files syntax checked. Reviewed renderer escaping of bookmark/history/download data, bounded session-only stores, isolated window launch arguments/environment, owned-chrome IPC, unique temporary download paths, explicit export/clear actions, legacy-default migration and custom-binding preservation, source-view identity boundaries and platform input handling. Documentation clearly states independent-process window semantics, ephemeral libraries and remaining Chrome-only/native-dialog differences; it does not falsely claim complete Chrome parity. Three focused commits, clean tree, version remains 1.0.2, proxy defaults still empty, updater metadata/blockmaps untouched, no release published, no private tooling or browsing captures tracked.

@iMumd
iMumd merged commit eba1f77 into main Nov 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant