Skip to content

Add consistent browser shortcuts, smooth tab controls and accurate About system fields - #5

Merged
iMumd merged 3 commits into
mainfrom
feat/browser-shortcuts-and-system-info
Nov 1, 2026
Merged

iMumd merged 3 commits into
mainfrom
feat/browser-shortcuts-and-system-info

Conversation

@iMumd

@iMumd iMumd commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Browser controls

Unify shortcut normalization and resolution across browser chrome and focused webviews. Fix Ctrl+Tab / Ctrl+Shift+Tab (previously discarded by normalization), respect custom bindings inside pages, preserve editing/IME/AltGraph input, and keep shifted gestures distinct. Add familiar aliases for numbered tabs, address focus, navigation, reload/hard reload, zoom, find/next/previous, fullscreen, print/save, DevTools and close-window. No global/system-wide keyboard hook.

Ctrl+Shift+T now reopens a genuinely closed URL/device entry with a new partition and fingerprint, rather than opening a blank tab. The stack is bounded to 10 entries, in memory only; cookies, storage, POST data and the old identity are not restored. Internal identity/device replacement does not populate it.

Responsiveness and focus

Keep active tabs visible and focus their page; new blank tabs focus the address bar without the new-tab page stealing focus. Honor native background-link disposition and adjacent placement; middle-click closes a tab. Remove/select tabs synchronously before session teardown to avoid stale-index races during rapid closing. Avoid background-load progress flicker and document-ready zoom resets, and respect reduced motion.

About

Both info APIs now use one actual runtime/OS collector. Show readable OS name/version/build, system versus application architecture, Node/Electron/Chromium and development/packaged status. Copied diagnostics do not collect usernames, hostname, local paths or browsing data. No Windows edition is guessed from kernel version, and tab spoofing does not change host diagnostics.

Validation

  • npm test: 34 tests plus rule-worker checks pass locally; syntax checked 51 JS files.
  • Real full application audit: 86/86 checks pass and process exits 0. Native Electron key/mouse input verifies page-textarea tab navigation, numbered tabs, custom guest bindings, recorder capture, new-tab address focus, close/reopen isolation, find matches, zoom, actual fullscreen, middle-click background links and About fields. Existing identity/storage/worker and interception/rule audits remain enabled.
  • The first complete run passed its assertions but crashed during forced test shutdown. The test runner now disposes guest sessions before app.exit; subsequent runs exit cleanly. Additional native tests exposed new-tab autofocus stealing the address bar; that was fixed, not skipped. Background-target assertions now wait for actual navigation readiness.
  • Windows CI runs the expanded real application audit; unit tests remain on Windows/Linux/macOS. All CI must pass before merge.

Compatibility and limits

Existing custom bindings are preserved. New/reset defaults move interception to Ctrl+Alt+I so Ctrl+Shift+I can open DevTools; legacy saved Ctrl+Shift+I interception remains until changed/reset. Closing the last tab still opens a fresh private tab; Ctrl+Shift+W closes the window. No new multi-window/bookmark/history manager is claimed. Native print/save dialogs and OS-specific packaged behavior require manual platform validation; docs/keyboard-shortcuts.md states this.

Three focused commits. Self-review, not independent approval. Version stays 1.0.2; no release or published assets changed. Private tooling remains outside the repo and default proxy pool remains empty.

@iMumd

iMumd commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

Self-review complete (not independent approval). CI run 41257294693 passed Windows, Linux and macOS. Verified the Windows job logs report 86/86 application checks and E2E_OK, not just unit-test success; the process exits cleanly. Local npm test passed 34 tests plus rule-worker checks, and the same full application suite passed 86/86. Reviewed exact modifier handling, recorder event consumption, primary/custom/alias precedence, bounded in-memory URL reopening with new sessions, synchronous tab removal before teardown, background-link placement/focus, new-tab autofocus, find request IDs, native fullscreen and consistent actual host diagnostics. Native print/save dialogs and packaged platform-specific gestures remain explicitly documented manual checks, not claimed automated coverage. Existing custom bindings and the last-tab behavior are preserved; no history database or multi-window manager is introduced. Three focused commits, clean working tree, version stays 1.0.2, no new release/assets, updater metadata/blockmaps untouched, default proxy pool still empty, and no private tooling added to tracked files.

@iMumd
iMumd merged commit e73d36a into main Nov 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant