Skip to content

Keep interception queue visible and validate all four live rule targets - #4

Merged
iMumd merged 3 commits into
mainfrom
fix/interceptor-queue-and-live-rules
Oct 30, 2026
Merged

iMumd merged 3 commits into
mainfrom
fix/interceptor-queue-and-live-rules

Conversation

@iMumd

@iMumd iMumd commented Oct 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Keep pending requests visible above the independently scrolling editor; auto-open the first and advance after Forward/Drop.
  • Preserve in-memory drafts while switching requests. Forward all submits the queue snapshot and saved drafts.
  • Scope pause IDs per tab, remove expired/detached records and retain failed continuations for correction.
  • Fix response-stage dispatch: Chrome sends Fetch.requestPaused with response metadata, not Fetch.responsePaused.
  • Enable body rewriting independently of manual interception, preserve transformed request bodies during Forward, and avoid double header application.
  • Preserve repeated Set-Cookie values, make plain dollar replacements literal, and reject invalid regexes on save.
  • Run live header/body work in bounded worker threads with deadlines and visible failures. Correct changed-response length, encoding and stale validators.
  • Repeat uses its source tab's session/proxy/cookies/CA and explicitly does not follow redirects.

Validation

Local npm test: 27 tests plus rule-engine worker checks pass. Local full application audit: 64/64 checks pass. The actual local HTTP fixture verifies all four plain and regex/capture targets while Intercept is off, all four non-idempotent transformations during manual Forward, cookie separation, a three-request queue with draft switching and real Drop/Forward effects, source-session Repeat cookies and redirect handling. The identity/frame/worker/storage/canvas/audio audit is included.

CI now runs the real application audits on Windows and preserves reports/captures, in addition to cross-platform unit tests, Linux replacement/fallback integration and the Windows metadata fallback fixture. All checks must pass before merging.

Limits and review

Self-review, not independent approval. docs/interception-and-rules.md documents value-only header matching, supported text/size/status cases, queue/deadline behavior, unchanged-traffic fallback on rule failures, and debugger interference. This is not a universal streaming/binary rewrite engine or a claim of Burp feature parity. No version bump, release or published-asset changes.

@iMumd

iMumd commented Oct 30, 2026

Copy link
Copy Markdown
Owner Author

Self-review complete (not independent approval). Local validation passed 27 unit/integration tests plus rule-worker checks and 64/64 application checks. CI run 41048253982 succeeded on all three platforms; the Windows job also executed the full real browser identity and live interception audits and preserved reports/captures. The first CI run exposed a missing Electron binary on the runner; the launcher now explicitly ensures the runtime and resolves its absolute path. The audits were retained, not bypassed. Reviewed per-tab Fetch IDs, draft preservation, continuation failure retention, worker deadlines, single-pass header/body rules, Set-Cookie preservation, source-session cookies/proxy replay, redirects and documented limits. No version or release changes.

@iMumd
iMumd merged commit 83b9e91 into main Oct 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant