Skip to content

Allow providing custom ssl context #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhegner wants to merge 1 commit into from
Closed

Allow providing custom ssl context #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sagemcom_api/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import json
import math
import random
from ssl import SSLContext
from types import TracebackType
from typing import Any
import urllib.parse
Expand Down Expand Up @@ -78,6 +79,7 @@
session: ClientSession | None = None,
ssl: bool | None = False,
verify_ssl: bool | None = True,
ssl_context: SSLContext | None = None
):
"""
Create a SagemCom client.
Expand Down Expand Up @@ -106,8 +108,9 @@
else ClientSession(
headers={"User-Agent": f"{DEFAULT_USER_AGENT}"},
timeout=ClientTimeout(DEFAULT_TIMEOUT),
connector=TCPConnector(

Check failure on line 111 in sagemcom_api/client.py

View workflow job for this annotation

GitHub Actions / Python 3.9 

Argument "verify_ssl" to "TCPConnector" has incompatible type "Optional[bool]"; expected "bool"  [arg-type]

Check failure on line 111 in sagemcom_api/client.py

View workflow job for this annotation

GitHub Actions / Python 3.10 

Argument "verify_ssl" to "TCPConnector" has incompatible type "bool | None"; expected "bool"  [arg-type]

Check failure on line 111 in sagemcom_api/client.py

View workflow job for this annotation

GitHub Actions / Python 3.11 

Argument "verify_ssl" to "TCPConnector" has incompatible type "bool | None"; expected "bool"  [arg-type]

Check failure on line 111 in sagemcom_api/client.py

View workflow job for this annotation

GitHub Actions / Python 3.12 

Argument "verify_ssl" to "TCPConnector" has incompatible type "bool | None"; expected "bool"  [arg-type]
verify_ssl=verify_ssl if verify_ssl is not None else True
verify_ssl=verify_ssl,
ssl_context=ssl_context
),
)
)
Expand Down
Loading