Repository navigation
ESP32: make the worker URL a build option instead of a source edit - #61
Merged
Merged
Conversation
- README: the IR engine allocates heap for payloads, so drop "zero-allocation"; the drop folder takes the 1-bit and two-plane BMPs the image preparer exports, not any BMP, and type 1626 targets cap files at 24 KB; NFC scan only fills the barcode when the tag's NFC data decodes; there is no test-pattern feature; the FAQ now says this app needs a Flipper even though the protocol does not. - CONTRIBUTING: the Android companion app was removed in d608afb. - wrangler.toml pointed users at a "WiFi Setup -> Server URL" field that never existed. Say how the URL is actually set today. - cloud_client.h described a runtime override through cloud_client_set_url(), which nothing calls. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
cloud_client.h hard-coded the worker URL, and wrangler.toml pointed users at a "WiFi Setup -> Server URL" field that has never existed, so anyone self-hosting cloud-plugins/ had to edit a header. cloud_client_set_url() exists but has no callers, and the UART protocol has no frame for it. Add CONFIG_TT_CLOUD_URL (Kconfig.projbuild, menu "TagTinker") defaulting to the current URL, and take TT_CLOUD_DEFAULT_URL from it. Setting it in sdkconfig.defaults or through menuconfig is now enough; rebuild and reflash still apply, and there is no hidden run-time channel. Also says so in wrangler.toml and the README WiFi Plugins bullet. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud_client.hhard-coded the worker URL, andwrangler.tomltold users to point the firmware at their own deployment through a "WiFi Setup -> Server URL" field that has never existed.cloud_client_set_url()is present but has no callers, and the UART protocol has no frame for it, so self-hostingcloud-plugins/meant editing a header.This adds
CONFIG_TT_CLOUD_URL(Kconfig.projbuild, menu "TagTinker"), defaulting to the URL used today, and takesTT_CLOUD_DEFAULT_URLfrom it. Setting it insdkconfig.defaultsor throughidf.py menuconfigis now enough. A rebuild and reflash are still required, and no hidden run-time configuration channel is added.Also corrected in
wrangler.tomland the README WiFi Plugins bullet.Based on #59, which corrects the same
wrangler.tomlcomment. Merge that one first.Verification
Built with ESP-IDF v5.2.8, target esp32s2, from a clean
sdkconfigeach time:https://string in the binary is the current worker URL, andsdkconfigshowsCONFIG_TT_CLOUD_URL="https://tagtinker.jhackerr.workers.dev".CONFIG_TT_CLOUD_URL="https://my-own-worker.example.workers.dev"added tosdkconfig.defaults: that is the onlyhttps://string in the binary.Not yet flashed to hardware.
🤖 Generated with Claude Code