Repository navigation
Guard unknown-profile targets and a full target list - #57
Merged
Merged
Conversation
A tag whose type code is not in the profile table gets a zeroed profile: kind Unknown, 0x0, Mono. NFC scan, targets.txt and web_job.txt (and the unreachable phone-sync code) all create such targets, and because only Segment was excluded they were offered Set Text, Set Image and WiFi Plugins. Set Text on a 0x0 job reaches malloc(0), which the firmware treats as a fatal error. - Offer Set Text, Set Image and WiFi Plugins only for dot-matrix profiles found in the table; the app has no display size for others. - Show Tag Info says the type is not in the profile table and which actions are hidden, instead of reporting "Size: 0x0" and "Color: Mono". - Refuse a 0x0 text job before either sized text path allocates. - Manual barcode entry with all 16 slots used now shows "Target List Full". It used to open Target Actions with selected_target -1, where Show Tag Info and LED Test index targets[-1]. - Widget buttons call back on press, short press and release, so the Back button went back twice. Act on the short press only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A tag whose type code is not in the profile table gets a zeroed profile: kind Unknown, 0x0, Mono. NFC scan,
targets.txtandweb_job.txtall create such targets. Because only Segment tags were excluded, these targets were offered Set Text, Set Image and WiFi Plugins. Set Text on a 0x0 job reachesmalloc(0), which official and Momentum firmware treat as a fatal error.selected_target-1, where Show Tag Info and LED Test indextargets[-1].Independent of #56 and #54; merges cleanly with both.
Verification
🤖 Generated with Claude Code