Consuming artifacts as static libraries instead of injecting them into build graph - #36
Open
goltsmannn wants to merge 1 commit into
Open
Consuming artifacts as static libraries instead of injecting them into build graph#36goltsmannn wants to merge 1 commit into
goltsmannn wants to merge 1 commit into
Conversation
KrishKittur
reviewed
Sep 1, 2026
| self.requires("foxglove-websocket/1.4.0", transitive_headers=True) | ||
| self.requires("protobuf/5.29.3", transitive_headers=True) | ||
| self.requires("boost/1.80.0") | ||
| self.requires("boost/1.80.0", options={"header_only": True}) |
Collaborator
There was a problem hiding this comment.
why did this change? We don't want boost to be a header only library as it will slow down build times.
Author
There was a problem hiding this comment.
I didn't see where boost was used at runtime and this dependency breaks compilation for a mac.
It is irrelevant to the transition.
Collaborator
There was a problem hiding this comment.
I've built on mac and not had issues with boost. Can you post the error here? Even if this isn't relevant to the changes we don't want to change things we don't need to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HT_PROTO transition: hytech-racing/HT_proto#29