Joseph huang local environments#76
Open
huangjoseph45 wants to merge 8 commits intomainfrom
Open
Conversation
Local Stack for s3
huangjoseph45
requested review from
SreeDan and
ryanlau
and removed request for
ryanlau
SreeDan
reviewed
Jan 22, 2026
| // Create an aws s3 service client | ||
| client := s3.NewFromConfig(cfg, func(o *s3.Options) { | ||
| o.BaseEndpoint = aws.String(endpoint) | ||
| o.UsePathStyle = os.Getenv("ENV") == "DEVELOPMENT" |
Contributor
There was a problem hiding this comment.
Maybe make DEVELOPMENT a const string you just use here.
Contributor
Author
There was a problem hiding this comment.
What do you mean?
Contributor
There was a problem hiding this comment.
For example:
...
const DevelopmentEnv = "DEVELOPMENT" // At the top of the file under the imports
...
o.UsePathStyle = os.Getenv("ENV") == DevelopmentEnvPutting this const in this file isn't the greatest but I think it's fine until we have a better way to organize our env variables
huangjoseph45
force-pushed
the
JosephHuangLocalEnvironments
branch
from
bdec035 to
684a632
Compare
ryanlau
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted dockercompose to run mongodb + localstack
added dev env to automatically use local dbs
adjused docker compose to override .env with .env.development if exists