Fix: open as text link on downloads now uses utf-8 encoding#1109
Open
ArneBab wants to merge 38 commits intohyphanet:nextfrom
Open
Fix: open as text link on downloads now uses utf-8 encoding#1109ArneBab wants to merge 38 commits intohyphanet:nextfrom
ArneBab wants to merge 38 commits intohyphanet:nextfrom
Conversation
Bombe
reviewed
Nov 9, 2025
Thanks to Bombe for the review!
Unfortunately, it currently looks like we won’t be able to update to a newer version than 3, because Mockito starts using WeakReference as a type for some internal representation or other, so we can’t mock objects anymore that use it.
And add a test for it.
…n-as-plain-text-utf8
FProxyToadlet does not even reject anything, so the Accept headers are almost completely useless; however, for a number of accepted MIME types we are following redirects automatically, and that’s what this test is supposed to verify.
…n-as-plain-text-utf8
javax.activation was a part of the JDK until Java 9, when it was removed. By using the new API (even though the old one is still available in Java 8) we will remove that hurdle when switching to a newer version of Java.
…n-as-plain-text-utf8
Bombe
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny change, replaces most of the use-cases of the much more complex and incorrect #970