Add copy-to-clipboard element for upload/download lists.#1099
Open
ArneBab wants to merge 11 commits intohyphanet:nextfrom
Open
Add copy-to-clipboard element for upload/download lists.#1099ArneBab wants to merge 11 commits intohyphanet:nextfrom
ArneBab wants to merge 11 commits intohyphanet:nextfrom
Conversation
bertm
suggested changes
Aug 29, 2025
Contributor
bertm
left a comment
There was a problem hiding this comment.
Feature-wise this is nice, the implementation could use some additional care.
Contributor
That can totally be worked around by putting the translated texts into an invisbile |
Also dataset key renaming.
Contributor
Author
|
@bertm @Bombe Thank you for your review (despite the not so great shape of the code)! I addressed all comments now:
I left out the spacing adjustments because they were not needed with the SVG. The SVG is added via innerHTML, but as static data, so it does not pose a risk (no escaping necessary). Can you give this another look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title text currently cannot be internationalized, because I wanted to keep the initialization out of the Toadlets.