Skip to content

fix: correct return type of useChain hook#32

Merged
theothersideofgod merged 1 commit intohyperweb-io:mainfrom
2wheeh:fix/optional-wallet-get-chain-wallet
Oct 22, 2025
Merged

fix: correct return type of useChain hook#32
theothersideofgod merged 1 commit intohyperweb-io:mainfrom
2wheeh:fix/optional-wallet-get-chain-wallet

Conversation

@2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented Oct 22, 2025

With current tsconfig ("strictNullChecks": false), TS infers return type of Array.find() as non-nullable, even though it can return undefined at runtime.

This leads type mismatch here:

const walletStore = this.wallets.find(w => w.info.name === walletName);

This returns undefined as well.

There are more potential type mismatches of this sort.
Turning on strictNullChecks would be a more desirable solution in the long term.

@theothersideofgod theothersideofgod merged commit 42423c1 into hyperweb-io:main Oct 22, 2025
2 checks passed
@2wheeh 2wheeh deleted the fix/optional-wallet-get-chain-wallet branch October 23, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants