Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions src/interface/lsp/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -487,16 +487,11 @@ mod tests {
let lsp = VqlutLsp::new();
let result = lsp.handle_completion(make_completion_params(0, 0));
if let Some(CompletionResponse::Array(items)) = result {
// All items should be keywords (no schema tables/columns).
assert!(
items
.iter()
.all(|i| i.kind == Some(CompletionItemKind::KEYWORD)),
"without schema, all items should be keywords"
);
assert!(
!items.is_empty(),
"should return at least some keyword completions"
assert_eq!(
items.len(),
3,
Comment on lines +490 to +492
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix wrong completion keyword count expectation

test_completion_without_schema_returns_only_keywords now asserts exactly 3 completion items, but handle_completion currently always seeds 13 keyword items before schema-based additions. This makes the test fail in the default no-schema path and will break CI even though behavior is correct. The assertion should validate keyword-only semantics (or derive count from the keyword list) rather than hardcoding 3.

Useful? React with 👍 / 👎.

"without schema, only 3 keywords expected, got {}",
items.len()
);
}
}
Expand Down
Loading