Skip to content

fix(audit): mangled escaping swallowed the closing quote #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
Aug 26, 2026
Merged

fix(audit): mangled escaping swallowed the closing quote #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/security-audit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ else
fi

# Check for dangerous path patterns
if grep -rq "\\.\\./\|\\.\\.\\\\\" "$IMPL_DIR/src" | grep -v "test\|comment"; then
if grep -rqE '\.\./|\.\.\\' "$IMPL_DIR/src"; then

@codacy-production codacy-production Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Suggestion: The fix correctly addresses the shell escaping issue but removes the noise-filtering logic for tests and comments. This will lead to high noise in audit results. Re-implement the filter using a pipeline that correctly excludes these patterns and checks the exit status.

Suggested change
if grep -rqE '\.\./|\.\.\\' "$IMPL_DIR/src"; then
if grep -rE '\.\./|\.\.\\' "$IMPL_DIR/src" | grep -vE 'test|comment' | grep -q .; then

check "Hardcoded traversal patterns" "WARN" "Found ../ patterns - verify they're safe"
else
check "Hardcoded traversal patterns" "PASS"
Expand Down
Loading