policy: Bun is tier 1, Deno is being removed — correct local CLAUDE.md - #156
Conversation
Owner ruling 2026-08-26: "deno is to go and bun is the way we are going, put it
first everywhere unless not possible and explain why if not".
This file is what an agent reads FIRST and it listed Bun as BANNED with Deno as
its replacement. Correcting hyperpolymath/standards (#655) fixes one copy of
~372 - agents read the local one. This is that local copy.
ALLOWED **Deno** "Replaces Node/npm/bun" -> **Bun** tier 1
BANNED | Bun | Deno | -> row REMOVED
BANNED Node.js / npm / pnpm/yarn -> Deno -> -> Bun
rule "No package.json for runtime deps - use deno.json imports"
-> Use package.json + bun.lock; a manifest is REQUIRED
rule "No node_modules in production"
-> bun install --production, pinned via bun.lock
pkg JS deps: Deno -> JS deps: Bun (package.json + bun.lock), bunx
WHY THE MANIFEST RULE MATTERS MOST. "No package.json for runtime deps" did not
express a preference - it told repos not to declare their dependencies at all.
hyperpolymath/ubicity imported zod and glob, shipped NO manifest of any kind,
and could not build under ANY toolchain. Fixed in ubicity#107; the rule that
caused it is fixed here.
ALSO REPAIRED - blanking scars from the ReScript purge, which substituted the
token with an EMPTY STRING rather than removing the text:
| | AffineScript | -> | ReScript | AffineScript |
1. **No new files** ... -> **No new ReScript files** ...
| **JavaScript** | Only where cannot | -> Only where AffineScript cannot
Restoring the NAME in a policy table does not reintroduce the language. Same
root cause as the rm -rf /lib found in wordpress-tools#62.
Policy text only - no code, no workflows, no build files. 1 file(s).
NOT FOLDED IN: "Fallback: Nix (flake.nix)" is stale (Guix superseded Nix per
ADR-2026-STACK-MIGRATION) but that is a separate ruling; flagged, not changed.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe project guidance changes the JavaScript and TypeScript toolchain from Deno to Bun. It updates runtime, compilation, API, dependency, package manifest, installation, and banned-tool guidance. ChangesBun toolchain migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
The PR establishes Bun as the Tier 1 JS/TS runtime and removes Deno from the allowed toolset, aligning with the core intent. Codacy quality checks indicate the changes are up to standards.
However, there is a significant gap between the PR description and the implementation: the promised restoration of ReScript policy text (updating Rule 1 and the BANNED table) is missing from the diff. Additionally, while Deno was removed from the ALLOWED table, it was not explicitly added to the BANNED table, which may lead to ambiguity for AI agents. A conflict also exists between the note on Bun's native TypeScript support and the project's existing ban on new TypeScript files in favor of AffineScript.
About this PR
- The PR description mentions restoring policy text and names lost during the ReScript purge, specifically updating Rule 1 and the BANNED table. These changes are currently missing from the files and should be included to fulfill the stated intent.
Test suggestions
- Verify Bun is listed as Tier 1 and default in ALLOWED table
- Verify Deno is replaced by Bun in the BANNED table replacements
- Verify mandatory manifest rule (package.json + bun.lock) is present
- Verify production install command (bun install --production) is documented
- Verify Rule 1 is updated to mention 'No new ReScript files' as per the description
- Verify the restoration of 'ReScript' in the BANNED table as described
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify Rule 1 is updated to mention 'No new ReScript files' as per the description
2. Verify the restoration of 'ReScript' in the BANNED table as described
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| | pnpm/yarn | Deno | | ||
| | Node.js | Bun | | ||
| | npm | Bun | | ||
| | pnpm/yarn | Bun | |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Suggestion: Since Deno is being replaced by Bun, it should be explicitly added to the BANNED table to ensure AI agents do not utilize it.
| | pnpm/yarn | Bun | | |
| pnpm/yarn | Bun | | |
| Deno | Bun | |
| | **AffineScript** | Primary application code | Affine-typed, compiles to typed-wasm or Deno-ESM | | ||
| | **Deno** | Runtime & package management | Replaces Node/npm/bun | | ||
| | **AffineScript** | Primary application code | Affine-typed, compiles to typed-wasm or ESM | | ||
| | **Bun** | JS/TS runtime & package management (tier 1) | Default for all new work. Executes `.ts` directly, no build step. Uses an npm-compatible `package.json` plus `bun.lock` — both are expected, not anti-patterns. | |
There was a problem hiding this comment.
⚪ LOW RISK
Nitpick: The note for Bun regarding direct .ts execution conflicts with Enforcement Rule 1, which bans new TypeScript files. Since the project uses AffineScript (which compiles to ESM), consider updating the note to reflect Bun's role as a runtime for the compiled output rather than its raw TS support.
| | **Bun** | JS/TS runtime & package management (tier 1) | Default for all new work. Executes `.ts` directly, no build step. Uses an npm-compatible `package.json` plus `bun.lock` — both are expected, not anti-patterns. | | |
| **Bun** | JS/TS runtime & package management (tier 1) | Default for all new work. Executes compiled ESM directly. Uses an npm-compatible package.json plus bun.lock — both are expected, not anti-patterns. | |
Review feedback from codacy-production and coderabbitai on the policy wave. Three substantive points, all accepted: 1. ".ts CONTRADICTION" (codacy, MEDIUM, raised on most of the wave). The Bun row said "Executes .ts directly, no build step" in a file whose BANNED table bans TypeScript. OWNER RULING: TypeScript "should not exist at all", so advertising Bun's TypeScript capability is wrong regardless of whether it is true. Every .ts reference is removed from the row, including "JS/TS" in its label. 2. "DENO MISSING FROM BANNED" (codacy, raised repeatedly). The wave removed Deno from ALLOWED but never added it to BANNED, so the ruling was only half expressed. Added | Deno | Bun |. 3. "UNPINNED bunx" (coderabbitai, Security & Privacy). A bare `bunx <tool>` can fetch a package outside package.json/bun.lock, and can start Node via a shebang - both contrary to estate SHA-pinning doctrine and the Node ban. Guidance now requires a declared devDependency plus `bunx --no-install --bun <tool>`. NOT taken: "a npm-compatible" (LanguageTool is wrong, "an" is correct before a vowel sound); "--frozen-lockfile is redundant" (correct - no change needed, and none made); the Nix->Guix point (real, but a separate ruling, deliberately not folded into a Deno/Bun change).
Addresses the two live static-analysis findings on this PR. ReScript was absent from the BANNED table although canon bans it (destination AffineScript), so the table read as permitting it. Enforcement Rule 3 said `bun install --production` with no `--frozen-lockfile`, so a lockfile mismatch silently re-resolved instead of failing, which defeats the point of committing `bun.lock`. Enforcement Rule 1 is deliberately untouched: standards#655 records that collision as not resolvable unilaterally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
1 participant
Owner ruling, 2026-08-26:
This repo's
.claude/CLAUDE.mdis what an agent reads first. Correctinghyperpolymath/standards(#655) fixes one copy of ~372 — agents read the local one.What this PR actually changes
Every line below was verified present in this PR's own diff — nothing is claimed that isn't here.
| Bun | Deno |row removedpackage.json+bun.lock)bun install --productionreplaces the node_modules rulebunx --no-install --bunOnly where cannot→ Only where AffineScript cannot| **** |→ AffineScriptReview feedback addressed
.tsdirectly" inside a file that bans TypeScript. Owner ruling: TypeScript should not exist at all — so every.tsreference is gone from the row, including JS/TS in its label. It now reads JS runtime, running compiled ESM/JS.bunx(coderabbitai, Security & Privacy): a barebunx <tool>can fetch a package outsidebun.lockand can start Node via a shebang. Guidance now requires a declared devDependency plusbunx --no-install --bun.Not taken: "a npm-compatible" (LanguageTool is wrong — "an" is correct before a vowel sound); "
--frozen-lockfileis redundant" (correct, and no such flag was added); the Nix → Guix point (real, but a separate ruling — deliberately not folded into a Deno/Bun change).Scope
Policy text only — no code, no workflows, no build files.
Related: #655 (governing document), #658 (Deno→Bun assessment: 18 repos blocked on
@affinescript/*npm packages that do not exist), #659 (policy duplicated into ~372 copies).