Skip to content

fix(tests): terminate find -exec and pass {} — the placeholder step was a no-op #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyperpolymath wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): terminate find -exec and pass {} — the placeholder step was a no-op #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/e2e/template_instantiation_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ find "$TEST_REPO_PATH" -type f \
sed -i "s|$placeholder|$value|g" "$file"
fi
done
' _ "$file"
' _ {} \;

@codacy-production codacy-production Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

The subshell script references "$file", but the filename found by find is passed as the first positional argument ($1). Because the command is in a single-quoted string, you must either assign the variable inside the subshell (e.g., sh -c 'file="$1"; ...') or replace "$file" with "$1" throughout the script block.

Try running the following prompt in your coding agent:

In tests/e2e/template_instantiation_test.sh, update the find -exec shell command to assign the first argument to the file variable by adding file="$1"; to the start of the sh -c string.


log_pass "All placeholder tokens replaced"

Expand Down