fix(ci): unbreak workflow YAML and add a complete actions.lock - #99
Conversation
Remediates GitHub Workflow Dependency Locking (public preview), which rejects runs at startup_failure with zero jobs and no logs. See hyperpolymath/standards#657. Five steps, in order, because each blocks the next: 1. Unbroke any workflow whose `permissions:` carried a scalar with an indented mapping under it - blind-permissions-insertion damage. This matters beyond the one file: gh actions-lock refuses to run when ANY workflow in the repo fails to parse, so the repo could never acquire a lockfile and could never self-heal. 2. Repinned hyperpolymath/standards reusables off commits that have no actions.lock. The rejection requires the CALLEE to be covered at the pinned SHA, which is unsatisfiable at a pre-lockfile commit. 3. Generated the lockfile with gh actions-lock. 4. Hand-added the reusable-workflow caller entries the tool omits, as '<path>': []. Measured across 218 repos: P(startup_failure | has lockfile) = 91.7% vs 15.8% without, because every workflow a lockfile OMITS is rejected. A PARTIAL lock is worse than none - running gh actions-lock and stopping there is how this outage spread. 5. Restored SPDX-License-Identifier to line 1, which the tool displaces with its own banner and which the workflow-security linter greps with head -1. Verified before push: 0 unparseable workflows, lockfile covers every workflow with no omissions, SPDX on line 1 in every file. Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead -> 0 startup_failure, 13 running. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (26)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis change updates 26 GitHub Actions workflows. It adds ChangesWorkflow maintenance
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 8 high |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR aims to stabilize CI workflows by fixing YAML syntax and implementing dependency locking. However, the analysis shows that the repository is currently not up to standards according to Codacy, primarily due to high-risk security practices introduced or maintained in this change.
Several workflows are pinning actions to the @main branch or reverting from immutable SHAs to mutable tags, which creates significant supply-chain risks. Additionally, a logical error in the Scorecard workflow causes a required permission to be dropped. A critical blocker for verification is that the actions.lock file mentioned in the PR title is missing from the diff, making it impossible to confirm the completeness of the locking strategy.
About this PR
- The '.github/workflows/actions.lock' file is excluded from the diff. This prevents verification of the dependency locking completeness and the manual entries for reusable callers described in the PR intent.
1 comment outside of the diff
.github/workflows/workflow-linter.yml
line 41⚪ LOW RISK
The suggested license header in the error message (MPL-2.0) contradicts the project's actual license (AGPL-3.0-or-later) seen in other workflow files.
Test suggestions
- Verify that all workflow YAML files are parseable and valid.
- Verify that every workflow file starts with the correct SPDX license identifier.
- Verify that 'actions: read' permission is present in all workflows that call external reusables (e.g., Governance, Hypatia, Mirror).
- Verify that the 'actions.lock' file contains entries for all workflows, including manually added path entries for reusable callers.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the 'actions.lock' file contains entries for all workflows, including manually added path entries for reusable callers.
Low confidence findings
- The diff for '.github/workflows/e2e.yml' shows 'permissions: read-all' but lacks sufficient context to verify if the syntax error (indented mapping under a scalar) has been fully resolved.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
|
||
| - name: Create GitHub Release | ||
| uses: softprops/action-gh-release@3d0d9888cb7fd7b750713d6e236d1fcb99157228 # v2 | ||
| uses: softprops/action-gh-release@v3.0.2 |
There was a problem hiding this comment.
🔴 HIGH RISK
This change replaces a previously pinned commit SHA with a version tag (v3.0.2). While tags are more readable, they are mutable—an owner of the softprops/action-gh-release repository could move the tag to point to a different commit. For workflows like release.yml that possess elevated permissions (contents: write), pinning to an immutable SHA is the recommended security best practice to prevent supply-chain attacks.
Try running the following prompt in your IDE agent:
Resolve the commit SHA for tag 'v3.0.2' of 'softprops/action-gh-release' and update its reference in .github/workflows/release.yml to use the SHA for improved security.
| - name: Validate K9 contracts | ||
| if: steps.detect.outputs.k9_count > 0 | ||
| uses: hyperpolymath/k9-ecosystem/validate-action@89f3c2702f4f650a92aa7411502f38da06abd562 # main | ||
| uses: hyperpolymath/k9-ecosystem/validate-action@main |
There was a problem hiding this comment.
🔴 HIGH RISK
Using the main branch for a third-party action is insecure as it makes your CI pipeline vulnerable to breaking changes or malicious injections if the upstream repository is compromised. Version tags or SHAs should be used instead.
Try running the following prompt in your IDE agent:
Pin the GitHub Action 'hyperpolymath/k9-ecosystem/validate-action' in .github/workflows/dogfood-gate.yml to its current commit SHA instead of the 'main' branch.
| - name: Validate A2ML manifests | ||
| if: steps.detect.outputs.count > 0 | ||
| uses: hyperpolymath/a2ml-ecosystem/validate-action@aa4b836bd969df2bc58128cb8e3d20bbc88d5e79 # main | ||
| uses: hyperpolymath/a2ml-ecosystem/validate-action@main |
There was a problem hiding this comment.
🔴 HIGH RISK
Sourcing an action from a branch reference (@main) is a significant security risk. Unlike version tags, a branch is a moving target; any commit to the upstream repository will immediately affect your CI pipeline. Even when using a lockfile manager like actions-lock, the primary workflow definition should ideally point to a stable tag or SHA to ensure auditability and defense-in-depth.
Try running the following prompt in your IDE agent:
Pin the GitHub Action 'hyperpolymath/a2ml-ecosystem/validate-action' in .github/workflows/dogfood-gate.yml to its current commit SHA instead of the 'main' branch.
| jobs: | ||
| scorecard: | ||
| uses: hyperpolymath/standards/.github/workflows/scorecard-reusable.yml@81dbf2dd854b1444fd6236fa2352474383b2c2b9 | ||
| uses: hyperpolymath/standards/.github/workflows/scorecard-reusable.yml@84355587cb2a1f86e6882de83514a32db2646e7a |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The job-level permissions block for the scorecard job overrides the workflow-level declaration and omits the newly added actions: read permission. This may cause failures in the 'actions-lock' audit or the reusable workflow execution. Add actions: read to the job-level permissions block.




Remediates GitHub Workflow Dependency Locking (public preview, no changelog entry), which rejects runs at
startup_failure— zero jobs, no logs, nothing in REST or GraphQL. Full analysis:hyperpolymath/standards#657.Proven on
hyperpolymath/anamnesis: 6 of 6 workflows dead → 0startup_failure, 13 running.Five steps, in order — each blocks the next
1. Unbreak the workflow YAML. Any
permissions:carrying a scalar with an indented mapping under it:This reaches past the one file:
gh actions-lockrefuses to run when any workflow in the repo fails to parse, so the repo can never acquire a lockfile and can never self-heal.2. Repin
standardsreusables off commits with noactions.lock. The rejection requires the callee to be covered at the pinned SHA — unsatisfiable at a pre-lockfile commit.3. Generate the lockfile with
gh actions-lock.4. Hand-add the reusable-caller entries the tool omits, as
'<path>': [].P(startup_failure | has lockfile) = 91.7%vs15.8%without — because every workflow a lockfile omits is rejected. A partial lock is worse than none. Runninggh actions-lockand stopping there is how this outage spread.5. Restore
SPDX-License-Identifierto line 1, which the tool displaces with its own banner and which the workflow-security linter greps viahead -1.Verified before this PR was opened
0unparseable workflows · lockfile covers every workflow, no omissions · SPDX on line 1 in every file. The script refuses to push if any of the three fails.🤖 Generated with Claude Code