Skip to content

fix(ci): unbreak workflow YAML and add a complete actions.lock - #37

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking
Aug 27, 2026
Merged

fix(ci): unbreak workflow YAML and add a complete actions.lock#37
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Remediates GitHub Workflow Dependency Locking (public preview, no changelog entry), which rejects runs at startup_failure — zero jobs, no logs, nothing in REST or GraphQL. Full analysis: hyperpolymath/standards#657.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead → 0 startup_failure, 13 running.

Five steps, in order — each blocks the next

1. Unbreak the workflow YAML. Any permissions: carrying a scalar with an indented mapping under it:

permissions: read-all
  actions: read        # <- mapping under a scalar. Unparseable.

This reaches past the one file: gh actions-lock refuses to run when any workflow in the repo fails to parse, so the repo can never acquire a lockfile and can never self-heal.

2. Repin standards reusables off commits with no actions.lock. The rejection requires the callee to be covered at the pinned SHA — unsatisfiable at a pre-lockfile commit.

3. Generate the lockfile with gh actions-lock.

4. Hand-add the reusable-caller entries the tool omits, as '<path>': [].

⚠️ Measured across 218 repos: P(startup_failure | has lockfile) = 91.7% vs 15.8% without — because every workflow a lockfile omits is rejected. A partial lock is worse than none. Running gh actions-lock and stopping there is how this outage spread.

5. Restore SPDX-License-Identifier to line 1, which the tool displaces with its own banner and which the workflow-security linter greps via head -1.

Verified before this PR was opened

0 unparseable workflows · lockfile covers every workflow, no omissions · SPDX on line 1 in every file. The script refuses to push if any of the three fails.

🤖 Generated with Claude Code

Remediates GitHub Workflow Dependency Locking (public preview), which
rejects runs at startup_failure with zero jobs and no logs. See
hyperpolymath/standards#657.

Five steps, in order, because each blocks the next:

1. Unbroke any workflow whose `permissions:` carried a scalar with an
   indented mapping under it - blind-permissions-insertion damage. This
   matters beyond the one file: gh actions-lock refuses to run when ANY
   workflow in the repo fails to parse, so the repo could never acquire a
   lockfile and could never self-heal.

2. Repinned hyperpolymath/standards reusables off commits that have no
   actions.lock. The rejection requires the CALLEE to be covered at the
   pinned SHA, which is unsatisfiable at a pre-lockfile commit.

3. Generated the lockfile with gh actions-lock.

4. Hand-added the reusable-workflow caller entries the tool omits, as
   '<path>': []. Measured across 218 repos: P(startup_failure | has
   lockfile) = 91.7% vs 15.8% without, because every workflow a lockfile
   OMITS is rejected. A PARTIAL lock is worse than none - running
   gh actions-lock and stopping there is how this outage spread.

5. Restored SPDX-License-Identifier to line 1, which the tool displaces
   with its own banner and which the workflow-security linter greps with
   head -1.

Verified before push: 0 unparseable workflows, lockfile covers every
workflow with no omissions, SPDX on line 1 in every file.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead -> 0
startup_failure, 13 running.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath merged commit cfab8a2 into main Aug 27, 2026
2 of 4 checks passed
@hyperpolymath
hyperpolymath deleted the fix/workflow-dependency-locking branch August 27, 2026 05:39
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e13467d3-b80f-47be-a6af-712a99163d98

📥 Commits

Reviewing files that changed from the base of the PR and between 47f6a49 and cf90fa7.

⛔ Files ignored due to path filters (1)
  • .github/workflows/actions.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • .github/workflows/changelog-gate.yml
  • .github/workflows/ci.yml
  • .github/workflows/codeql.yml
  • .github/workflows/hypatia-scan.yml
  • .github/workflows/main-estate-audit.yml
  • .github/workflows/push-email-notify.yml
  • .github/workflows/release.yml
  • .github/workflows/secret-scanner.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated automated workflow action versions for more consistent maintenance.
    • Improved workflow metadata and licensing information.
    • Added read-only action permissions to the secret-scanning workflow.
    • Updated security scanning and notification workflow references.

Walkthrough

The pull request updates eight GitHub Actions workflows. It adds gh actions-lock comments, changes action references, updates a reusable workflow commit, adds an SPDX header, and grants actions: read permission.

Changes

GitHub Actions updates

Layer / File(s) Summary
Action and reusable workflow references
.github/workflows/changelog-gate.yml, .github/workflows/ci.yml, .github/workflows/codeql.yml, .github/workflows/hypatia-scan.yml, .github/workflows/main-estate-audit.yml, .github/workflows/push-email-notify.yml, .github/workflows/release.yml
The workflows now use the specified actions/checkout, CodeQL, email, and reusable workflow references.
Workflow metadata and permissions
.github/workflows/main-estate-audit.yml, .github/workflows/secret-scanner.yml
The workflows add management metadata. main-estate-audit.yml adds an SPDX header. secret-scanner.yml adds actions: read permission.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit checks the workflow trail
Tags replace the locked-up rail
Comments mark the keeper’s hand
Read permissions now are planned
Green checks hop across the land


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Security 1 high

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is currently not up to standards. While the intent is to 'unbreak' workflow YAML and implement dependency locking, the actual diff is missing the core deliverables: the '.github/workflows/actions.lock' file and the specific permissions block syntax fixes described in the PR summary.

A critical security concern was found in the 'push-email-notify.yml' workflow, where a pinned commit SHA was replaced with a mutable tag, increasing the risk of supply chain attacks for a workflow that handles sensitive credentials. Additionally, several workflows still target the mutable '@main' branch, which contradicts the goal of full dependency locking.

About this PR

  • Major components described in the PR are missing from the diff: the '.github/workflows/actions.lock' file is not present, and the YAML syntax fix for the 'permissions' blocks is not visible in the provided hunks.

Test suggestions

  • Verify that every workflow file starts with the SPDX-License-Identifier comment on line 1.
  • Ensure all workflow files are valid YAML and specifically that the 'permissions' block does not contain a mapping nested under a scalar.
  • Verify that all reusable workflows (e.g., Hypatia) are pinned to specific commit SHAs.
  • Check for the presence of 'actions: read' permission in workflows, which is required for the lockfile validation mechanism.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Ensure all workflow files are valid YAML and specifically that the 'permissions' block does not contain a mapping nested under a scalar.
Low confidence findings
  • The PR description mentions a local validation script used to verify the lockfile before pushing. Including this script in the repository would ensure all contributors can maintain the lockfile integrity.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

steps:
- name: Send push notification email
uses: dawidd6/action-send-mail@0bbdab096651ee93f37ec02383e088183d41ff0b # pinned
uses: dawidd6/action-send-mail@v3.12.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

Pinning third-party actions to a full 40-character commit SHA is a security best practice to prevent supply chain attacks via mutable tags. This is especially important for this workflow as it utilizes sensitive SMTP credentials.

See Issue in Codacy

- uses: actions/checkout@v7.0.1

- name: Required Files Gate
uses: hyperpolymath/cicd-suite/actions/required-files-check@main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Suggestion: Step 'Required Files Gate' (and subsequent gates) uses '@main'. For a complete and robust lockfile implementation as described in the PR intent, these should be pinned to a specific version tag or commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant