Skip to content

fix(ci): restore the Scorecard SARIF upload deleted in June (security detection is currently OFF) #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
Aug 26, 2026
+19 −3
Merged

fix(ci): restore the Scorecard SARIF upload deleted in June (security detection is currently OFF) #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/actions.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ workflows:
- 'actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a'
- 'ossf/scorecard-action@2d1146689b8cda280b9bc96326124645441f03bc'
'.github/workflows/scorecard-reusable.yml':
- 'github/codeql-action@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28'
- 'actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1'
- 'actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a'
- 'ossf/scorecard-action@2d1146689b8cda280b9bc96326124645441f03bc'
Expand Down
21 changes: 18 additions & 3 deletions .github/workflows/scorecard-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,28 @@ jobs:
- name: Run Scorecard Analysis
uses: ossf/scorecard-action@2d1146689b8cda280b9bc96326124645441f03bc # v2.4.4
with:
results_file: results.json
results_format: json
results_file: results.sarif
results_format: sarif
# publish_results feeds the public OpenSSF API and the badge, and is
# INDEPENDENT of results_format -- so emitting SARIF does not cost us
# the badge. Both outputs are live with this shape.
publish_results: true

# RESTORED 2026-08-25. Commit 5a93d9d5 (PR #393, "Ci/gitleaks self hosted
# fix", 2026-06-21) deleted this step and switched results_format to json
# as collateral of an unrelated gitleaks refactor. Without a SARIF upload
# nothing feeds GitHub code scanning, so every Scorecard alert in the
# estate froze: measured in this repo on 2026-08-25, all 12 Scorecard
# alerts were stuck at 2026-06-03 while Hypatia's updated 2026-08-24.
# The badge kept working, which is why it went unnoticed.
- name: Upload SARIF to code scanning
uses: github/codeql-action/upload-sarif@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v3
with:
sarif_file: results.sarif

- name: Upload results artifact
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: scorecard-results
path: results.json
path: results.sarif
retention-days: 90
Loading