You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This release fixes a remote memory exhaustion issue in the quinn-proto Assembler. See GHSA-4w2j-m93h-cj5j for more details and #2694 for the fix.
Two sponsoring organizations participated in coordinated disclosure. If this is relevant to your organization, please contact us to keep support Quinn maintenance.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
@dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
@dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
@dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
@dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
You can disable automated security fix PRs for this repo from the Security Alerts page.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses several critical security vulnerabilities by updating quinn-proto (to address remote memory exhaustion and memory safety) and rand (to fix a memory safety violation during UniformChar deserialization). Codacy analysis indicates the changes are up to standards with no new issues or complexity increases.
A minor scope discrepancy exists: the PR title indicates updates for a single directory, but the changes span both dipstick/services/collector and polygraph/backend. The security risk mitigations include fixes for GHSA-qfwj-vfxf-92j2, GHSA-2hv7-gw8g-gpq5, and GHSA-hmxj-32vh-65vr.
About this PR
The PR title specifies updates across 1 directory, but Cargo.lock files for both dipstick/services/collector and polygraph/backend are modified. Verify if this multi-directory update is intentional.
Test suggestions
Validate the project builds successfully with the bumped dependencies.
Verify that quinn-proto 0.11.17 does not introduce regressions in the collector's network communication.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Validate the project builds successfully with the bumped dependencies.
2. Verify that quinn-proto 0.11.17 does not introduce regressions in the collector's network communication.
Low confidence findings
The diff provided for the Cargo.lock files makes it difficult to verify the specific changes to dependency constraints. Ensure the resulting versions align exactly with the security fix requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependenciesPull requests that update a dependency filerustPull requests that update rust code
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependabot
Bot
added
dependencies
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Bumps the cargo group with 2 updates in the /dipstick/services/collector directory: quinn-proto and rand.
Updates
quinn-protofrom 0.11.14 to 0.11.17Release notes
Sourced from quinn-proto's releases.
Commits
0343120proto: bump version to 0.11.17d7bf3d0Limit total memory used to buffer outgoing datagrams31ca5d2Limit total memory used to buffer incoming datagrams3a78b60Factor out DatagramBuffer for queues in either directionb37ced3proto: check limits when processing already retired CIDs6a984b8proto: extract method for checking CID retirements499dba8proto: bound assembler chunk count regardless of over-allocation33ce0c2congestion: saturate CUBIC window increment to avoid overflowc8ad7e6fix(ci): fix clippy lintsa96949fTake semver-compatible update for anyhowUpdates
randfrom 0.9.2 to 0.9.5Changelog
Sourced from rand's changelog.
Commits
3474ec0rand v0.9.5: backport #1790 (#1803)ba4c4c6Prepare v0.9.4: fix doc build (#1766)4b8b686Document new error-handling behaviour for ReseedingRng6c25c6dPrepare v0.9.4: fix doc build1aeee9fPrepare v0.9.3: deprecate featurelog(#1764)98473eePrepare rand 0.9.2 (#1648)031a1f5examples/print-next.rs(#1647)6cb75eeMake UniformUsize serializable (#1646)0c955c5Add some tests for BlockRng, BlockRng64 and Xoshiro RNGs (#1639)204084aFix: Remove accidental editor swap file (#1636)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.