-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ci): unbreak workflow YAML and add a complete actions.lock #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # This workflow is managed by gh actions-lock. | ||
| # This workflow is managed by gh actions-lock. | ||
| name: ci | ||
| on: | ||
| push: | ||
|
|
@@ -18,7 +19,7 @@ | |
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v7.0.1 | ||
| - uses: dtolnay/rust-toolchain@6d9817901c499d6b02debbb57edb38d33daa680b # stable | ||
| - uses: dtolnay/rust-toolchain@v1 | ||
|
Check failure on line 22 in .github/workflows/ci.yml
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 HIGH RISK Using a mutable version tag like '@v1' instead of a full length commit SHA allows the action to change without notice. Pinning to a SHA is the only way to ensure the action is immutable and the build is reproducible. Find the current commit SHA for dtolnay/rust-toolchain@v1 and replace the tag with that SHA. |
||
| with: | ||
| components: rustfmt, clippy | ||
| - uses: actions/cache@v6.1.0 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # This workflow is managed by gh actions-lock. | ||
| # This workflow is managed by gh actions-lock. | ||
| # Dormant push-email notification. ARMED by setting the repo variable | ||
| # PUSH_EMAIL_ENABLED=true (the single on/off switch). Addresses are pre-filled; | ||
| # sending needs the org SMTP secrets (SMTP_HOST/PORT/USER/PASS). Inherited by | ||
|
|
@@ -17,7 +18,7 @@ | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Send push notification email | ||
| uses: dawidd6/action-send-mail@v18 | ||
| uses: dawidd6/action-send-mail@v3.12.0 | ||
|
Check failure on line 21 in .github/workflows/push-email-notify.yml
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 HIGH RISK The version changed from @v18 to @v3.12.0. Please confirm if this downgrade is intended. Regardless, this third-party action should be pinned to a full length commit SHA rather than a mutable tag to prevent potential malicious code injection if the tag is ever updated or overwritten. |
||
| with: | ||
| server_address: ${{ secrets.SMTP_HOST }} | ||
| server_port: ${{ secrets.SMTP_PORT }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ LOW RISK
Nitpick: Redundant duplicate comment: This line is identical to line 2. Please remove the extra management header here and in all other workflow files modified in this PR.