chore: fill or remove RSR template placeholders - #90
Conversation
openssf-compliance.yml fails when any of the thirteen files it checks
still contains a {{PLACEHOLDER}} token. This clears them.
Three kinds of change, no invention:
The "TEMPLATE INSTRUCTIONS (delete this block before publishing)" comment
is deleted. The template says to delete it, and it is where every legend
line lives -- so a large share of the reported tokens were the file
documenting its own placeholders, not real unfilled fields.
Tokens derivable from the repository are filled: owner and repo from the
git remote, project name, year, forge, main branch, contact email.
PGP and website lines are removed rather than filled, because nothing
true could go in them. https://github.com/<user>.gpg returns HTTP 200 for
every account; with no key uploaded the body is a stub reading "This user
hasnt uploaded any GPG keys". No key is published for either account
here, and commit signing in this estate is SSH, which is unrelated. Only
one repository in the estate has a domain, so {{WEBSITE}} likewise has no
correct value. The template sanctions this: "Optional: Remove sections
that dont apply (e.g. PGP if you dont use it)." A security policy telling
a researcher to encrypt to a key that does not exist is worse than one
that does not mention encryption.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. CI failed: CI failures caused by a banned ReScript file check violation and an invalid GitHub Actions commit reference for CodeQL.OverviewTwo distinct job failures occurred in CI: a governance check failure due to a tracked ReScript test file, and a workflow configuration error failing to resolve a commit SHA for the CodeQL action. FailuresBanned ReScript File Violation (confidence: high)
Invalid Action Commit SHA Resolution (confidence: high)
Summary
Code Review ✅ Approved 6 resolved / 6 findingsReplaces repository template placeholders to satisfy openssf-compliance checks, but leaves multiple critical and important issues including an unaddressed placeholder in CODE_OF_CONDUCT.md, misconfigured package metadata in guix.scm, and retained PGP keys in SECURITY.md. ✅ 6 resolved✅ Bug: guix.scm renamed protocol-squisher -> squisher-corpus (wrong repo)
✅ Quality: README cross-reference made self-referential
✅ Bug: CODE_OF_CONDUCT.md still contains {{PLACEHOLDER}} token
✅ Bug: guix.scm license changed to PMPL-1.0, contradicts SPDX header
✅ Bug: SECURITY.md keeps PGP key/TBD fingerprint the PR claims to remove
...and 1 more resolved from earlier reviews Tip Comment OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
1 participant
openssf-compliance.ymlfails when any of the thirteen files it checks still contains a{{PLACEHOLDER}}token. This clears them, with no invention.TEMPLATE INSTRUCTIONS (delete this block before publishing)comment — the template says to delete it, and it is where every legend line lived, so a large share of the reported tokens were the file documenting its own placeholders.https://github.com/<user>.gpgreturns HTTP 200 for every account; with no key uploaded the body is a stub reading "This user hasn't uploaded any GPG keys". No key is published for either account, and commit signing here is SSH — unrelated. The template sanctions this: "Optional: Remove sections that don't apply (e.g. PGP if you don't use it)."\n\nA security policy telling a researcher to encrypt to a key that does not exist is worse than one that does not mention encryption.\n\nWhere applicable, this also fixes a misrouted advisory URL. A previousjust initcopied already-filled templates out ofsquisher-corpus, so 51 repositories directed vulnerability reports tohyperpolymath/squisher-corpus— a repository unrelated to the code being reported, meaning the affected maintainer never saw them. Repointed from this repository's own git remote.