fix(ci): unbreak workflow YAML and add a complete actions.lock - #103
Conversation
Remediates GitHub Workflow Dependency Locking (public preview), which rejects runs at startup_failure with zero jobs and no logs. See hyperpolymath/standards#657. Five steps, in order, because each blocks the next: 1. Unbroke any workflow whose `permissions:` carried a scalar with an indented mapping under it - blind-permissions-insertion damage. This matters beyond the one file: gh actions-lock refuses to run when ANY workflow in the repo fails to parse, so the repo could never acquire a lockfile and could never self-heal. 2. Repinned hyperpolymath/standards reusables off commits that have no actions.lock. The rejection requires the CALLEE to be covered at the pinned SHA, which is unsatisfiable at a pre-lockfile commit. 3. Generated the lockfile with gh actions-lock. 4. Hand-added the reusable-workflow caller entries the tool omits, as '<path>': []. Measured across 218 repos: P(startup_failure | has lockfile) = 91.7% vs 15.8% without, because every workflow a lockfile OMITS is rejected. A PARTIAL lock is worse than none - running gh actions-lock and stopping there is how this outage spread. 5. Restored SPDX-License-Identifier to line 1, which the tool displaces with its own banner and which the workflow-security linter greps with head -1. Verified before push: 0 unparseable workflows, lockfile covers every workflow with no omissions, SPDX on line 1 in every file. Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead -> 0 startup_failure, 13 running. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe workflows add ChangesWorkflow reference updates
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 2 high |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
The PR aims to stabilize GitHub Actions workflows by fixing YAML syntax errors and implementing a comprehensive lockfile mechanism. While it successfully addresses the identified startup failures and ensures internal workflows are pinned to specified commits, the overall analysis is not up to standards. The review identified critical security concerns regarding the use of mutable tags for actions that handle sensitive credentials or trigger cross-repository events. Specifically, workflows for email notifications and repository dispatching should be pinned to immutable commit SHAs to prevent potential supply-chain attacks. Addressing these security practices is necessary to ensure the integrity of the CI/CD pipeline.
About this PR
- The use of mutable version tags for GitHub Actions that handle sensitive credentials or tokens represents a security risk. Transitioning to immutable commit SHAs across all workflows is recommended to prevent potential supply-chain attacks where a tag could be redirected to malicious code.
Test suggestions
- Verify SPDX-License-Identifier is preserved on line 1 in all modified workflows
- Verify 'managed by gh actions-lock' banner is present on line 2
- Update/Pin actions/checkout to v7.0.1 across all applicable workflows
- Repin hyperpolymath/standards reusable workflows to current SHAs
- Update CodeQL actions to v4.37.7
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| steps: | ||
| - name: Trigger Propagation | ||
| uses: peter-evans/repository-dispatch@28959ce8df70de7be546dd1250a005dd32156697 # v3 | ||
| uses: peter-evans/repository-dispatch@v4.0.1 |
There was a problem hiding this comment.
🔴 HIGH RISK
Pin the 'peter-evans/repository-dispatch' action to a full 40-character commit SHA. This ensures that the code being executed is exactly what was intended and has not been tampered with.
| steps: | ||
| - name: Send push notification email | ||
| uses: dawidd6/action-send-mail@0bbdab096651ee93f37ec02383e088183d41ff0b # pinned | ||
| uses: dawidd6/action-send-mail@v3.12.0 |
There was a problem hiding this comment.
🔴 HIGH RISK
Pin the 'dawidd6/action-send-mail' action to a full 40-character commit SHA to ensure immutability and protect sensitive SMTP credentials.
Remediates GitHub Workflow Dependency Locking (public preview, no changelog entry), which rejects runs at
startup_failure— zero jobs, no logs, nothing in REST or GraphQL. Full analysis:hyperpolymath/standards#657.Proven on
hyperpolymath/anamnesis: 6 of 6 workflows dead → 0startup_failure, 13 running.Five steps, in order — each blocks the next
1. Unbreak the workflow YAML. Any
permissions:carrying a scalar with an indented mapping under it:This reaches past the one file:
gh actions-lockrefuses to run when any workflow in the repo fails to parse, so the repo can never acquire a lockfile and can never self-heal.2. Repin
standardsreusables off commits with noactions.lock. The rejection requires the callee to be covered at the pinned SHA — unsatisfiable at a pre-lockfile commit.3. Generate the lockfile with
gh actions-lock.4. Hand-add the reusable-caller entries the tool omits, as
'<path>': [].P(startup_failure | has lockfile) = 91.7%vs15.8%without — because every workflow a lockfile omits is rejected. A partial lock is worse than none. Runninggh actions-lockand stopping there is how this outage spread.5. Restore
SPDX-License-Identifierto line 1, which the tool displaces with its own banner and which the workflow-security linter greps viahead -1.Verified before this PR was opened
0unparseable workflows · lockfile covers every workflow, no omissions · SPDX on line 1 in every file. The script refuses to push if any of the three fails.🤖 Generated with Claude Code