fix(agentic): substitute the template self-name - #73
Conversation
AGENTIC.a2ml still identified this repo as its own template:
# AGENTIC.a2ml - AI agent interaction patterns for rsr-template-repo
project = "rsr-template-repo"
An agent reading this file to learn what repo it is in was told
"rsr-template-repo".
Measured context: across 1,018 AGENTIC.a2ml copies in the estate this is
the ONLY unsubstituted self-name left. The other occurrences of the
string are deliberate prose - chronicles-of-slavia narrates its own past
leak, boj-server-cartridges cites the template's ADR - so this is the
last real instance, not the first of many.
Cause: `just repo-init`'s token-substitution pass rewrites placeholder
tokens, and a separate pass handles the self-name, but this file was
instantiated before or outside that second pass. Not a licence change,
so LICENCE-POLICY A2 does not apply.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
|
| Layer / File(s) | Summary |
|---|---|
Update AGENTIC project identity .machine_readable/6a2/AGENTIC.a2ml |
The file description and agentic-config.project value now use proof-burrower. The configuration version remains 1.0.0. |
Estimated code review effort: 1 (Trivial) | ~2 minutes
Merge Risk: ⚪ Minimal · up to bb682
This localized change corrects the repository self-name in one agent guidance file without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review.
Poem
A rabbit checks the project name,
proof-burrowernow marks the frame.
The version stays at one point oh,
No other settings change or flow.
Hop, hop, the config is clear!
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description explains the change, scope, rationale, and related issue. It omits the required Changes section, RSR Quality Checklist, and Testing section from the repository template. | Add the required template sections. List the key changes, complete the RSR Quality Checklist with applicable items checked, and describe the tests performed. State when screenshots are not applicable. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and concisely describes the main change: replacing the template self-name in the AGENTIC configuration. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Create stacked PR
- Commit on current branch
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The pull request is 'Up to Standards' and aligns with the expected configuration updates. No security flaws, major logic bugs, or quality issues were identified that should prevent merging.
While the manual replacement of placeholders fulfills the immediate requirement, the change lacks automated enforcement. The existing validation script, scripts/check-no-placeholders.sh, was not updated to reflect these changes, which leaves a minor gap for potential regressions in future project derivations.
About this PR
- The change is implemented as a manual fix without updating the
scripts/check-no-placeholders.shscript or adding automated validation. This omission makes the repository susceptible to future regressions where template strings could be re-introduced or configuration keys misconfigured without detection.
Test suggestions
- Verify that AGENTIC.a2ml contains the correct project name in the header and configuration fields.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that AGENTIC.a2ml contains the correct project name in the header and configuration fields.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
.machine_readable/6a2/AGENTIC.a2mlstill identified this repo as its own template:An agent reading this file to learn what repo it is in was told
rsr-template-repo.Scope: this is the last one
Measured across 1,018
AGENTIC.a2mlcopies in the estate, this is the only unsubstituted self-name remaining. The other occurrences of that string are deliberate prose —chronicles-of-slavianarrates its own past leak,boj-server-cartridgescites the template ADR. So this is the last real instance, not the first of many.Placeholder hygiene is otherwise clean: scanning all 1,018 for
{{…}},${…},PROJECT_NAME,REPLACE_ME,PENDING,TODO,FIXMEand others returns only false positives (prose about placeholders).rsr-template-repo/scripts/check-no-placeholders.shis doing its job — it simply does not check the self-name.Not a licence change, so
LICENCE-POLICY.adocA2 does not apply.Related:
standards#646.🤖 Generated with Claude Code