fix(ci): the invisible-character gate never matched anything - #56
fix(ci): the invisible-character gate never matched anything#56hyperpolymath wants to merge 1 commit into
Conversation
MEASURED 2026-08-27: this gate's pattern caught 0 OF 6 invisible-character test
cases. It has never detected an NBSP, zero-width space, BOM, soft hyphen, bidi
override or word joiner.
ROOT CAUSE: the pattern used UTF-8 BYTE sequences (\xc2\xa0) while grep -P
matches CHARACTERS. Bytes c2 a0 are ONE character U+00A0; \xc2\xa0 asks for TWO
characters, U+00C2 then U+00A0, which is never present.
grep -P '\xc2\xa0' -> miss
grep -P '\x{a0}' -> MATCH
Only \x00 worked, being single-byte in both readings.
FIXED: codepoint escapes; C0 control characters \x01-\x08,\x0B,\x0C,\x0E-\x1F
added (TAB/LF/CR excluded); and grep -a, without which grep skips any NUL-bearing
file as binary.
The C0 range matters: a stray BACKSPACE byte made a workflow unparseable in
developer-ecosystem, so it never ran, and this linter called it clean.
Canonical fix: hyperpolymath/empty-linter#70. 1 file(s) here.
VERIFIED: YAML re-parsed, and the corrected pattern was confirmed to catch a real
NBSP before the change was kept.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (12)
🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesInvisible-character gate
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to The workflow’s invisible-character matcher may reject the BOM expression on GNU grep 3.8, causing the gate to fail or miss BOM-containing files. This is a bounded correctness risk that should be resolved or explicitly accepted before merge. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description clearly states the root cause, implemented fixes, affected character classes, and verification results. It does not use all template headings or include the checklist, but the required technical information is mostly present. Full details: Linked Issues checkExplanation The changes satisfy the codepoint escape, C0 control, and grep -a requirements in [ Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
The transition to PCRE-compatible codepoint escapes and the expanded character range (including C0 control characters) addresses the identified failure in the invisible-character gate. While the PR meets Codacy quality standards, the absence of automated regression tests for these regex patterns increases the risk of future silent failures. Additionally, the command used for file scanning in the workflow is currently inefficient and potentially unreliable for capturing aggregate exit statuses; optimizing this via file batching is recommended.
About this PR
- There are no automated regression tests (such as a sample 'dirty' file) within the repository to verify that the new regex patterns remain effective or to prevent future regressions. It is recommended to add a test script or a dedicated test file containing these invisible characters to ensure the gate remains functional.
Test suggestions
- Verify detection of Non-Breaking Space (U+00A0)\n- [ ] Verify detection of C0 control character like Backspace (U+0008)\n- [ ] Verify detection of Byte Order Mark (U+FEFF)\n- [ ] Verify that a file containing a null byte is scanned rather than skipped
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify detection of Non-Breaking Space (U+00A0)\n- [ ] Verify detection of C0 control character like Backspace (U+0008)\n- [ ] Verify detection of Byte Order Mark (U+FEFF)\n- [ ] Verify that a file containing a null byte is scanned rather than skipped
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| -o -name '*.idr' -o -name '*.zig' -o -name '*.v' -o -name '*.jl' \ | ||
| -o -name '*.gleam' -o -name '*.hs' -o -name '*.ml' -o -name '*.sh' \) \ | ||
| -exec grep -Prl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null | ||
| -exec grep -aPrl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Suggestion: The current implementation uses 'find -exec ... {} ;' which is inefficient because it spawns a separate 'grep' instance for every file. Switching to '+' allows 'find' to batch files, significantly improving performance and ensuring the exit status 'EL_EXIT' more reliably reflects whether matches were found across the entire set. Additionally, the '-r' flag is redundant when used with 'find', and adding '--' is a best practice to protect against filenames starting with hyphens.\n\nsuggestion\n -exec grep -aPl "$PATTERNS" -- {} + > /tmp/empty-lint-results.txt 2>/dev/null\n
1 participant
Measured 2026-08-27: this gate caught 0 of 6 invisible-character test cases. It has never detected an NBSP, zero-width space, BOM, soft hyphen, bidi override or word joiner.
Root cause
The pattern used UTF-8 byte sequences (
\xc2\xa0) whilegrep -Pmatches characters. Bytesc2 a0are one character U+00A0;\xc2\xa0asks for two, U+00C2 then U+00A0 — never present.Only
\x00worked, being single-byte in both readings. The gate ran, passed, and could not see what it exists to see.Fixed
\x01-\x08,\x0B,\x0C,\x0E-\x1Fadded (TAB/LF/CR excluded)grep -a— without it grep skips any NUL-bearing file as binaryThe C0 range matters: a stray backspace byte made a workflow unparseable in
developer-ecosystem, so it never ran — and this linter called it clean.Canonical fix: hyperpolymath/empty-linter#70. 1 file(s) here.
Verified: YAML re-parsed, and the corrected pattern was confirmed to catch a real NBSP before the change was kept.