Skip to content

fix(tests): terminate find -exec and pass {} — the placeholder step was a no-op #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
Aug 28, 2026
+1 −1
Merged

fix(tests): terminate find -exec and pass {} — the placeholder step was a no-op #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/e2e/template_instantiation_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ find "$TEST_REPO_PATH" -type f \
sed -i "s|$placeholder|$value|g" "$file"
fi
done
' _ "$file"
' _ {} \;

@codacy-production codacy-production Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

The sh -c command string uses the variable "$file", but the filename from find is passed as a positional argument ($1). Inside the subshell, "$file" will be empty. Additionally, because the script block is single-quoted, shell variables like $placeholder and $value will not expand.

Update the command to assign the file path (e.g., file="$1") and ensure all variables are correctly scoped or passed into the subshell. Try this prompt in your IDE agent:

In tests/e2e/template_instantiation_test.sh, update the find -exec block to correctly assign file="$1" and ensure $placeholder and $value are accessible inside the subshell script.


log_pass "All placeholder tokens replaced"

Expand Down
Loading