fix(ci): the invisible-character gate never matched anything - #72
fix(ci): the invisible-character gate never matched anything#72hyperpolymath wants to merge 1 commit into
Conversation
MEASURED 2026-08-27: this gate's pattern caught 0 OF 6 invisible-character test
cases. It has never detected an NBSP, zero-width space, BOM, soft hyphen, bidi
override or word joiner.
ROOT CAUSE: the pattern used UTF-8 BYTE sequences (\xc2\xa0) while grep -P
matches CHARACTERS. Bytes c2 a0 are ONE character U+00A0; \xc2\xa0 asks for TWO
characters, U+00C2 then U+00A0, which is never present.
grep -P '\xc2\xa0' -> miss
grep -P '\x{a0}' -> MATCH
Only \x00 worked, being single-byte in both readings.
FIXED: codepoint escapes; C0 control characters \x01-\x08,\x0B,\x0C,\x0E-\x1F
added (TAB/LF/CR excluded); and grep -a, without which grep skips any NUL-bearing
file as binary.
The C0 range matters: a stray BACKSPACE byte made a workflow unparseable in
developer-ecosystem, so it never ran, and this linter called it clean.
Canonical fix: hyperpolymath/empty-linter#70. 1 file(s) here.
VERIFIED: YAML re-parsed, and the corrected pattern was confirmed to catch a real
NBSP before the change was kept.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (25)
🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe empty-lint workflow now matches invisible characters by Unicode code point, includes additional control characters and the word joiner, and scans binary files as text. ChangesInvisible-character gate
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized workflow change makes the invisible-character gate detect the intended characters, including controls and NUL-bearing files, with no actionable merge-blocking risk remaining after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the defect, root cause, implemented fixes, affected file, and verification steps. It does not reproduce the repository checklist headings, but it is sufficiently complete and relevant. Full details: Linked Issues checkExplanation The changes satisfy the coding objectives in issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR successfully addresses the logic issue where the invisible-character CI gate was ineffective due to incorrect character escaping and binary-file skipping. By switching to Unicode codepoint escapes and adding the -a flag, the gate should now correctly identify the intended characters. While the implementation is up to standards according to Codacy, there is a notable absence of regression test files or fixtures to verify that these characters are actually detected. Including such files would ensure the gate remains functional in the future.
About this PR
- The PR does not introduce any test fixtures or regression-test files (e.g., a sample file containing targeted invisible characters) to ensure the gate remains functional and to verify the current fix works as intended.
Test suggestions
- Verify detection of Non-Breaking Space (U+00A0) in a source file
- Verify detection of C0 control characters (e.g., Backspace \x08) in a source file
- Verify detection of Zero-Width Space (U+200B) in a source file
- Ensure files containing null bytes (\x00) are scanned rather than skipped as binary
- Verify that allowed whitespace (TAB, LF, CR) does not trigger the gate
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify detection of Non-Breaking Space (U+00A0) in a source file
2. Verify detection of C0 control characters (e.g., Backspace \x08) in a source file
3. Verify detection of Zero-Width Space (U+200B) in a source file
4. Ensure files containing null bytes (\x00) are scanned rather than skipped as binary
5. Verify that allowed whitespace (TAB, LF, CR) does not trigger the gate
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| -o -name '*.idr' -o -name '*.zig' -o -name '*.v' -o -name '*.jl' \ | ||
| -o -name '*.gleam' -o -name '*.hs' -o -name '*.ml' -o -name '*.sh' \) \ | ||
| -exec grep -Prl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null | ||
| -exec grep -aPrl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null |
There was a problem hiding this comment.
⚪ LOW RISK
Suggestion: The -r flag is redundant when using find to provide explicit file paths. To improve performance in larger repositories, use + instead of \; to batch file processing. Additionally, removing the 2>/dev/null redirection is recommended to ensure that any grep errors, such as PCRE compilation failures, are visible in the CI logs.
| -exec grep -aPrl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null | |
| -exec grep -aPl "$PATTERNS" {} + > /tmp/empty-lint-results.txt |
1 participant
Measured 2026-08-27: this gate caught 0 of 6 invisible-character test cases. It has never detected an NBSP, zero-width space, BOM, soft hyphen, bidi override or word joiner.
Root cause
The pattern used UTF-8 byte sequences (
\xc2\xa0) whilegrep -Pmatches characters. Bytesc2 a0are one character U+00A0;\xc2\xa0asks for two, U+00C2 then U+00A0 — never present.Only
\x00worked, being single-byte in both readings. The gate ran, passed, and could not see what it exists to see.Fixed
\x01-\x08,\x0B,\x0C,\x0E-\x1Fadded (TAB/LF/CR excluded)grep -a— without it grep skips any NUL-bearing file as binaryThe C0 range matters: a stray backspace byte made a workflow unparseable in
developer-ecosystem, so it never ran — and this linter called it clean.Canonical fix: hyperpolymath/empty-linter#70. 1 file(s) here.
Verified: YAML re-parsed, and the corrected pattern was confirmed to catch a real NBSP before the change was kept.